tabulator: backwards compatible split for stable/25.1 #8795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include all tabulator logic, but do not include it as default yet. This commit includes some tabulator fixes that need to be backported to master
AdSchellevis
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
@swhite2 I've checked various forms and so far all seems to be working as before, when 25.7 is out, it might be practical to cleanup some of the *Initialized flags and move them to the jquery handle if possible (something like $("#my-target").isInitialized()), but that's not something we have to worry about now.
fichtner
reviewed
Jun 13, 2025
| '/ui/js/opnsense_bootgrid_plugin.js', | ||
|
|
||
| '/ui/js/tabulator.min.js', | ||
| // '/ui/js/opnsense_bootgrid.js', /* include for 25.7 */ |
There was a problem hiding this comment.
since stable/25.1 never meets stable/25.7 you can omit this
fichtner
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See first commit description for relevant cherry-picks. Second commit encapsulates all changes providing backwards compatibility.