This repository was archived by the owner on Jan 5, 2019. It is now read-only.
Fix info sent to intercom, including customer id #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ED0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coreylight sends customer ID to Myst and cleans up the intercom code a bit. FTR Emissary can post additional custom attributes to Myst/Intercom by sending a
custom_attributesobject as part of the user object it sends. (Using Intercom'scustom_attributesstuff forces some Intercom-specific logic into Emissary, so maybe it'd be better to have Myst transform a user object intocustom_attributeson its own like I did here for customer ID. Up 2 u!)