Fix Part of #4938: Create Admin Onboarding Intro(2/12) #5839
Conversation
…e-admin-intro # Conflicts: # app/src/main/java/org/oppia/android/app/profile/ProfileChooserActivityPresenter.kt # app/src/main/java/org/oppia/android/app/profile/ProfileLoginFragmentPresenter.kt
Moved start onboarding to intro activity Temporarily navigate to profile chooser until create profile nickname is completed Ensure all activities in the backstack are removed
Coverage ReportResultsNumber of files assessed: 14 Failure Cases
Passing coverageFiles with passing code coverage
Exempted coverageFiles exempted from coverage
|
|
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 23 KiB (Added) APK download size (estimated): 17 MiB (old), 17 MiB (new), 22 KiB (Added) Method count: 261118 (old), 261419 (new), 301 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6925 (old), 6935 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 19 MiB (old), 19 MiB (new), 23 KiB (Added)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 32 bytes (Added) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 40 bytes (Added) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 32 bytes (Added) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 56 bytes (Added) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 40 bytes (Added) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 32 bytes (Added) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 32 bytes (Added) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 66 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 64 KiB (Added) Method count: 118383 (old), 119159 (new), 776 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5881 (old), 5891 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 66 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 24 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 45 KiB (new), 40 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 24 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 40 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 32 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 24 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 24 bytes (Added) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 66 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 65 KiB (Added) Method count: 118389 (old), 119165 (new), 776 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5881 (old), 5891 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 66 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 24 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 45 KiB (new), 40 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 24 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 40 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 32 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 24 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 24 bytes (Added) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 66 KiB (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 66 KiB (Added) Method count: 118389 (old), 119165 (new), 776 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5881 (old), 5891 (new), 10 (Added)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 66 KiB (Added)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 24 bytes (Added) Configuration ldpiAPK file size: 44 KiB (old), 45 KiB (new), 40 bytes (Added) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 24 bytes (Added) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 40 bytes (Added) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 32 bytes (Added) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 24 bytes (Added) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 24 bytes (Added) |
# Conflicts: # app/src/main/java/org 8000 /oppia/android/app/splash/SplashActivityPresenter.kt # app/src/main/res/values-land/dimens.xml # app/src/main/res/values-sw600dp-land/dimens.xml # app/src/main/res/values-sw600dp-port/dimens.xml # model/src/main/proto/arguments.proto
Coverage ReportResultsNumber of files assessed: 14 Failure Cases
Passing coverageFiles with passing code coverage
Exempted coverageFiles exempted from coverage
|
|
Hi @deonwaju, @subhajitxyz, please do a review pass. Thanks. |
Coverage ReportResultsNumber of files assessed: 14 Passing coverageFiles with passing code coverage
Exempted coverageFiles exempted from coverage
|
| android:id="@+id/admin_intro_fragment_placeholder" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:orientation="vertical" /> |
There was a problem hiding this comment.
orientation isn’t applicable to FrameLayout, so it can be safely removed.
| /** Test tag for the otter image. */ | ||
| const val OTTER_TEST_TAG = "TEST_TAG.otter" | ||
|
|
||
| /** Test tag for the otter image. */ |
There was a problem hiding this comment.
I think , KDoc comment needs to updated.
| /** Test tag for the otter image. */ | ||
| const val BACK_BUTTON_TEST_TAG = "TEST_TAG.back_button" | ||
|
|
||
| /** Test tag for the otter image. */ |
There was a problem hiding this comment.
I think the KDoc comment needs to be updated.
| /** Adds a bezier curve background to a view. */ | ||
| @Composable | ||
| fun WavyBackgroundView(backgroundColorResId: Int) { | ||
| val whiteColor = colorResource(backgroundColorResId) |
There was a problem hiding this comment.
| val whiteColor = colorResource(backgroundColorResId) | |
| val waveColor = colorResource(backgroundColorResId) |
| } | ||
| else -> launchOnboardingActivity() |
There was a problem hiding this comment.
Is it possible that profile != null && profile.startedProfileOnboarding == false ??
| fun testActivity_hasCorrectActivityLabel() { | ||
| launch<AdminIntroActivity>(createAdminIntroActivityIntent()) | ||
| .use { scenario -> | ||
| scenario?.onActivity { activity -> |
There was a problem hiding this comment.
Just curious—why is scenario treated as nullable here?
|
Thanks @adhiamboperes , the UI looks awesome! I’ve taken an initial pass and left some comments. |
|
Hi @adhiamboperes, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue. |
Explanation
Fixes Part of #4938: Introduces the admin onboarding screen.
In #5378, the "I am a parent/Teacher" options routes to the profiles list screen, since admin onboarding has not been implemented yet. This PR creates the introduction screen, in which the user is informed of what it means to be an admin.
In #5387, the supervisor profile onboarding started on the profile type screen, and ended on the home screen. This workaround has been rewired so that supervisor onboarding starts on the introduction screen introduced in this PR.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: