8000 Test for all Sections Displayed in Correct Order by itsadityaaaaa · Pull Request #5853 · oppia/oppia-android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Test for all Sections Displayed in Correct Order #5853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Test for all Sections Displayed in Correct Order #5853

wants to merge 5 commits into from

Conversation

itsadityaaaaa
Copy link

Explanation

This PR create test to check the UI content is correct in portrait, Landscape and Tablet view

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

@itsadityaaaaa itsadityaaaaa requested a review from a team as a code owner June 11, 2025 15:18
@adhiamboperes
Copy link
Collaborator

@itsadityaaaaa, please look at the failing checks.

@itsaditya 8000 aaaa
Copy link
Author

@adhiamboperes I am working in the issue

@itsadityaaaaa itsadityaaaaa marked this pull request as draft June 13, 2025 05:01
@itsadityaaaaa
Copy link
Author

@adhiamboperes Is I have to take approval each time to run the workflow?

@itsadityaaaaa itsadityaaaaa marked this pull request as ready for review June 13, 2025 08:29
@itsadityaaaaa itsadityaaaaa marked this pull request as draft June 13, 2025 08:29
@adhiamboperes
Copy link
Collaborator

@adhiamboperes Is I have to take approval each time to run the workflow?

@itsadityaaaaa since you are a first time contributor yes, but this wont be required in your subsequent PRs.

You can run the checks locally in the meantime. Please see: https://github.com/oppia/oppia-android/wiki/Static-Analysis-Checks#how-to-run-static-checks-locally

@itsadityaaaaa itsadityaaaaa changed the title Write test for UI content in portrait, Landscape and tablet Test for all Sections Displayed in Correct Order Jun 14, 2025
@itsadityaaaaa itsadityaaaaa marked this pull request as ready for review June 14, 2025 15:31
@itsadityaaaaa
Copy link
Author

@adhiamboperes can you please re approve the workflow run

@itsadityaaaaa itsadityaaaaa marked this pull request as draft June 16, 2025 13:50
@adhiamboperes
Copy link
Collaborator
adhiamboperes commented Jun 20, 2025 8000

Hi @itsadityaaaaa, can we help with anything on this PR?

@itsadityaaaaa
Copy link
Author

Hi @adhiamboperes thank you for asking, actually I'm unable to resolve all the failing test due to my limited understanding in this project and also I'm unable to run all the tests in local environment it will be great if you could help

@adhiamboperes
Copy link
Collaborator

Hi @adhiamboperes thank you for asking, actually I'm unable to resolve all the failing test due to my limited understanding in this project and also I'm unable to run all the tests in local environment it will be great if you could help

@itsadityaaaaa, thanks for letting us know. @subhajitxyz can give you pointers on how to write a UI test (which screens to look at and sample tests), and you can create a new github discussion describing the issues you are facing while running tests locally. We'll be able to help.

@itsadityaaaaa
Copy link
Author

@subhajitxyz It will be very helpful if you can provide me pointer on how to write UI test and run all the unit and other tests in local environment.

@adhiamboperes
Copy link
Collaborator

@subhajitxyz It will be very helpful if you can provide me pointer on how to write UI test and run all the unit and other tests in local environment.

@itsadityaaaaa, there are instructions here: https://github.com/oppia/oppia-android/wiki/Installing-Oppia-Android#set-up-and-run-tests and https://github.com/oppia/oppia-android/wiki/Bazel-User-Guide#installation.

If you are facing issues with these wiki instructions, let us know.

@subhajitxyz
Copy link
Collaborator

Hi @itsadityaaaaa ,
Can you please update this branch? It will help us understand why these checks are failing.

For writing and learning UI tests, you can start by checking out StateFragmentTest. Generally, in StateFragment, we use a RecyclerView that displays different types of item views with the help of their corresponding view models.

In the app, you can play any exploration and see content, feedback, input fields, buttons—everything is displayed using the state_recycler_view.

You can go through StateFragmentTest to see how we generally test content, feedback, and other elements. It also shows how we play through an exploration and verify specific scenarios.

Here are some example tests for better understanding:

Guide for writing tests: link

To run tests on your local machine, you can follow this guide:
https://github.com/oppia/oppia-android/wiki/Bazel-User-Guide#running-tests

If you face any issues, feel free to reach out to me.

@itsadityaaaaa
Copy link
Author

@adhiamboperes @subhajitxyz Thank you, for your suggestion I will try all this stuff soon and come to you guys if encountered any other issue, Once again a big thank you for this.

@oppiabot OppiaBot
Copy link
oppiabot bot commented Jul 3, 2025

Hi @itsadityaaaaa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 3, 2025
@subhajitxyz subhajitxyz removed their assignment Jul 6, 2025
@oppiabot oppiabot bot removed the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 6, 2025
@oppiabot OppiaBot
Copy link
oppiabot bot commented Jul 13, 2025

Hi @itsadityaaaaa, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhiamboperes adhiamboperes Awaiting requested review from adhiamboperes adhiamboperes is a code owner automatically assigned from oppia/android-frontend-reviewers

At least 1 approving review is required to merge this pull request.

Assignees

@itsadityaaaaa itsadityaaaaa

Labels
stale Corresponds to items that haven't seen a recent update and may be automatically closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsadityaaaaa @adhiamboperes @subhajitxyz
0