8000 Agent type filter for policies endpoint by Cerfoglg · Pull Request #75 · orchestracities/anubis · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Agent type filter for policies endpoint #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 11, 2022
Merged

Agent type filter for policies endpoint #75

merged 8 commits into from
Apr 11, 2022

Conversation

Cerfoglg
Copy link
Collaborator

Proposed changes

Added the option to filter policies by agent type (e.g. acl:agent, acl:agentRole, acl:agentGroup)

Types of changes

What types of changes does your code introduce to the project: Put
an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after
creating the PR. If you're unsure about any of them, don't hesitate to
ask. We're here to help! This is simply a reminder of what we are going
to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the Contributor License Agreement
  • I have updated the RELEASE NOTES
  • I have added tests that prove my fix is effective or that my
    feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in
    downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion
by explaining why you chose the solution you did and what alternatives
you considered, etc...

@Cerfoglg Cerfoglg requested a review from chicco785 April 11, 2022 08:37
@github-actions
Copy link
Contributor
github-actions bot commented Apr 11, 2022 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@github-actions @Cerfoglg
autopep8 action fixes (#76)
8bb6961 
Co-authored-by: Cerfoglg <
8000
;Cerfoglg@users.noreply.github.com>
chicco785
chicco785 reviewed Apr 11, 2022
View reviewed changes
chicco785
chicco785 reviewed Apr 11, 2022
View reviewed changes
chicco785
chicco785 reviewed Apr 11, 2022
View reviewed changes
chicco785
chicco785 suggested changes Apr 11, 2022
View reviewed changes
Copy link
Contributor
@chicco785 chicco785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cerfoglg

  1. let's add a test combining different filters
  2. let's use "like" queries for the resources

@Cerfoglg Cerfoglg requested a review from chicco785 April 11, 2022 13:17
@chicco785 chicco785 merged commit 3e94ad4 into master Apr 11, 2022
@chicco785 chicco785 deleted the 60-policy-filtering branch April 11, 2022 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Alrea 5E22 dy have an account? Sign in.
Reviewers

@chicco785 chicco785 chicco785 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cerfoglg @chicco785
0