Integrate ShellCheck Validation for install.sh and run.sh Scripts - Edited yaml File #47
Conversation
|
We can probably use https://github.com/marketplace/actions/shellcheck for this. But first I'd like to decide whether if we actually want to use shellcheck or not in #46 |
|
I didn't think of using it directly via Marketplace. I'll take a look at that. I haven't done it before. There might be a better solution. I left a comment on the other PR request (#46 (comment)). I'm here if you need help. |
f8f22d9 to
159e6bb
Compare
|
Hop, it's me again. Based on your suggestion, I updated my existing PR to add ShellCheck verification for install.sh and run.sh scripts. Now we use the action ludeeus/action-shellcheck from GitHub Marketplace instead of manual installation. This makes the integration simpler and more maintainable. Once you've made your decision, you can proceed as you wish. Good luck. 🫡 Note: I simply tested it with the test branch (https://github.com/KaganCanSit/git-cliff-action/actions). But you may not want to scan the entire project directory. Just so you know. |
e786c1e to
0b49b08
Compare
0b49b08 to
2b08b15
Compare
2b08b15 to
f168cff
Compare
Hello again @orhun,
Yesterday during the release, I sent a merge request (#46) by performing a check for the run and install bash scripts. If we can handle that request and include it in the project, we can add a shellcheck check to the workflow for automatic checks. I also use this in my own workflow. It saves a lot of time. Of course, some warnings may need to be disabled. But this is a very rare situation.
I have done various tests on the repository I forked myself. (https://github.com/KaganCanSit/git-cliff-action/actions)
It will save a lot of time and effort.
I wanted to help. However, if there is something I want to change, you can reach me. I would like to help in my free time. I am open to learning.
Have a nice day!