8000 Get intralink information from rustdoc by orium · Pull Request #236 · orium/cargo-rdme · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Get intralink information from rustdoc #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Get intralink information from rustdoc #236

wants to merge 1 commit into from

Conversation

orium
Copy link
Owner
@orium orium commented May 31, 2024

Closes #177.

@orium orium mentioned this pull request Jul 28, 2024
Open
@orium orium force-pushed the rustdoc-json branch 2 times, most recently from 53084eb to 73101dd Compare December 27, 2024 21:48
@angrynode
Copy link

This branch is great! Some notes:

  • it allows unqualified links as asked in Allow intralinks that do not start with crate:: #151, removing the cargo doc warning about unnecessary complete path
  • it does not allow to resolve links without an actual URI (so you have to write [Api](Api) instead of just [Api] in usual rustdoc)
  • i had to bump some crates and EXPECTED_RUSTDOC_FORMAT_VERSION to 42 but all went fine
  • it complained at runtime that nightly toolchain was not installed... i wonder if there could be a way to statically bundle whatever's needed from nightly in a single cargo-rdme binary

@orium
Copy link
Owner Author
orium commented Mar 25, 2025

it complained at 8000 runtime that nightly toolchain was not installed... i wonder if there could be a way to statically bundle whatever's needed from nightly in a single cargo-rdme binary

I'm thinking about making cargo-rdme install by running cargo rdme setup or something like that.

@angrynode
Copy link

I'm thinking about making cargo-rdme install by running cargo rdme setup or something like that.

Would that work by running rustup at runtime? Are you aware if there's a way to bundle what's needed directly in the binary (maybe depending on feature flags), or a tracking issue for that on rust side? I personally very much prefer to have it all in the binary, but maybe it's just not possible at the moment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get intralink information from rustdoc
2 participants
@orium @angrynode
0