osmocom · ahmadbilal39515 · May 18, 2024 · May 18, 2024 · May 18, 2024 · May 19, 2024
diff --git a/.github/workflows/rubyonrails.yml b/.github/workflows/rubyonrails.yml
@@ -0,0 +1,17 @@
+name: "Ruby on Rails CI"
+on:
+  push:
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+      - name: Install Ruby and gems
+        uses: ruby/setup-ruby@55283cc23133118229fd3f97f9336ee23a179fcf # v1.146.0
+        with:
+          ruby-version: 3.2
+          bundler-cache: true
+      - name: Lint Ruby files
+        run: bundle exec rubocop --parallel
diff --git a/.gitignore b/.gitignore
@@ -1,5 +1,6 @@
 /.project
 /.idea
+/.vscode
 /.loadpath
 /.powrc
 /.rvmrc
@@ -24,12 +25,11 @@
 /log/mongrel_debug
 /plugins/*
 !/plugins/README
+/public/assets/*
 /public/dispatch.*
 /public/plugin_assets/*
-/public/themes/*
-!/public/themes/alternate
-!/public/themes/classic
-!/public/themes/README
+/themes/*
+!/themes/README
 /tmp/*
 /tmp/cache/*
 /tmp/pdf/*
@@ -46,3 +46,7 @@
 
 /node_modules
 yarn-error.log
+
+/config/credentials/production.key
+
+/config/master.key
diff --git a/.hgignore b/.hgignore
@@ -2,6 +2,7 @@ syntax: glob
 
 .project
 .idea
+.vscode
 .loadpath
 .powrc
 .rvmrc
@@ -24,6 +25,7 @@ lib/redmine/scm/adapters/mercurial/redminehelper.pyc
 lib/redmine/scm/adapters/mercurial/redminehelper.pyo
 log/*.log*
 log/mongrel_debug
+public/assets/*
 public/dispatch.*
 public/plugin_assets/*
 tmp/*

diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,8 +1,8 @@
 inherit_from: .rubocop_todo.yml
 
 AllCops:
-  TargetRubyVersion: 2.7
-  TargetRailsVersion: 6.1
+  TargetRubyVersion: 3.1
+  TargetRailsVersion: 7.2
 
   NewCops: enable
 
@@ -129,10 +129,18 @@ Rails/ActiveSupportOnLoad:
     # TODO: Need to check the impact on plugins. Disable for now.
     - 'lib/redmine/preparation.rb'
 
+Rails/ApplicationRecord:
+  Exclude:
+    - 'db/migrate/0*.rb'
+
 Rails/BulkChangeTable:
   Exclude:
     - 'db/migrate/20120714122200_add_workflows_rule_fields.rb'
+    - 'db/migrate/20130217094251_remove_issues_default_fk_values.rb'
     - 'db/migrate/20131214094309_remove_custom_fields_min_max_length_default_values.rb'
+    - 'db/migrate/20190510070108_add_unique_id_to_import_items.rb'
+    - 'db/migrate/20200826153402_add_totp_to_user.rb'
+    - 'db/migrate/20221012135202_add_index_to_custom_values.rb'
 
 Rails/CompactBlank:
   Enabled: false
@@ -160,6 +168,9 @@ Rails/Pluck:
 Rails/RootPathnameMethods:
   Enabled: false
 
+Rails/SkipsModelValidations:
+  Enabled: false
+
 Rails/SquishedSQLHeredocs:
   Enabled: false
 
@@ -201,7 +212,7 @@ Style/EmptyElse:
   EnforcedStyle: empty
 
 Style/FormatString:
-  EnforcedStyle: sprintf
+  Enabled: false
 
 Style/FormatStringToken:
   Enabled: false
@@ -220,6 +231,12 @@ Style/GlobalStdStream:
 
 Style/HashSyntax:
   EnforcedStyle: no_mixed_keys
+  EnforcedShorthandSyntax: either
+
+Style/HashEachMethods:
+  Exclude:
+    - 'db/migrate/072_add_enumerations_position.rb'
+    - 'db/migrate/078_add_custom_fields_position.rb'
 
 Style/IdenticalConditionalBranches:
   Exclude:
@@ -232,13 +249,22 @@ Style/InverseMethods:
 Style/NegatedIfElseCondition:
   Enabled: false
 
+Style/NumericPredicate:
+  Enabled: false
+
+Style/PerlBackrefs:
+  Enabled: false
+
 Style/RaiseArgs:
   Enabled: false
 
 Style/RedundantConstantBase:
   Exclude:
     - 'config/environments/production.rb'
 
+Style/RedundantParentheses:
+  Enabled: false
+
 Style/Semicolon:
   Enabled: false