Handle get_tags exception #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inferno-chromium
suggested changes
Feb 28, 2021
| try: | ||
| total_tags = self._repo.get_tags().totalCount | ||
| except Exception: | ||
| logger.error(f'get_tags is failed: {self._repo.url}') |
There was a problem hiding this comment.
Add a comment that this failure is usually due to large number of tags.
Also, i think we should default to 26, or whatever that constant for max release count is (use constant from that file). this just means we default to max threshold which is equivalent to having any value larger than it (since it caps it).
There was a problem hiding this comment.
Okay, added the comment: # Very large number of tags, i.e. 5000+. Cap at 26.
And returning RECENT_RELEASES_THRESHOLD as the default value
- Return default value
inferno-chromium
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we request
get_tagsfor this repo, GitHub API throws an exception (interestingly, this was the only repo that was persistent in throwing an exception):https://github.com/hortonworks/cloudbreak
It has 8,707 tags, so probably that's a large number for the API to process.
The only detail is that in catch block of "contributors", you return "10" as a default value. Should I set a similar default value for tags as well?