Included tests for scorer/config #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Included tests for ToAlgorithmInput(), LoadConfig(), and some for buildCondition()
- Couldn't test other functions because they returned functions, and they couldn't be compared.
- Included tests for ToAlgorithmInput(), LoadConfig(), and some for buildCondition() - Couldn't test other functions because they returned functions, and they couldn't be compared. Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
121b851 to
068fb02
Compare
calebbrown
requested changes
Nov 21, 2022
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
calebbrown
reviewed
Nov 22, 2022
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
calebbrown
approved these changes
Nov 22, 2022
calebbrown
requested changes
Nov 22, 2022
There was a problem hiding this comment.
Sorry, I didn't check the lint!
The issues are marked inline.
"GCI" issues can be fixed by putting the "cmp" import on a separate line above the "algorithm" import:
import (
//...
"github.com/google/go-cmp/cmp"
"github.com/ossf/criticality_score/internal/scorer/algorithm"
)The "fieldalignment" issues are not critical in tests and can be ignore by adding //nolint:govet above the struct.
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
f304536 to
88fcd22
Compare
calebbrown
requested changes
Nov 23, 2022
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Appreciate the feedback and the patience :) |
calebbrown
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.