8000 Reduce resources requested by the worker. by calebbrown · Pull Request #393 · ossf/criticality_score · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Reduce resources requested by the worker. #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2023
Merged

Reduce resources requested by the worker. #393

merged 2 commits into from
May 11, 2023

Conversation

calebbrown
Copy link
Contributor

No description provided.

@calebbrown
Reduce resources requested by the worker.
21dbeea 
Signe
8000
d-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown calebbrown requested a review from spencerschrock May 11, 2023 01:35
spencerschrock
spencerschrock previously approved these changes May 11, 2023
View reviewed changes
infra/envs/base/worker.yaml Outdated
@@ -33,10 +33,10 @@ spec:
imagePullPolicy: Always
resources:
requests:
memory: 5Gi
memory: 2Gi
Copy link
Member
@spencerschrock spencerschrock May 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: Azeem took a different approach in ossf/scorecard#2978 (see discussion here for details)
Does it make sense to remove the requests to allow GKE to handle scaling? You're of course more familiar with your resource needs, so feel free to resolve conversation as needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I removed the memory limits.

@calebbrown
Remove resource limits to help the autoscaler
fa65632 
Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown calebbrown requested a review from spencerschrock May 11, 2023 03:44
@calebbrown calebbrown merged commit 706c79b into main May 11, 2023
@calebbrown calebbrown deleted the smaller_pod branch May 11, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerschrock spencerschrock spencerschrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebbrown @spencerschrock
0