cmake.eclass: Default CMAKE_BUILD_TYPE=RelWithDebInfo in EAPI 8 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Support for KDE Frameworks, Plasma and Gear. Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Switch to using current working directory instead of ${S}
when initializing ${CMAKE_USE_DIR} and ${BUILD_DIR}.
Raise baseline cmake version to 3.18.
Bug: https://bugs.gentoo.org/704524
Thanks-to: Arfrever Frehtes Taifersar Arahesis <Arfrever@Apache.Org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Raise baseline Frameworks version to 5.82.0. Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
No other changes needed? |
Not that I can think of. We've already improved support for non-Gentoo build types in the past. |
b886e68 to
f84ab20
Compare
047845a to
e89caf9
Compare
a17r
added a commit
that referenced
this pull request
Jun 13, 2025
- _cmake_minverreq-detect(): New function for reusability of regex - Optimise #1: Reuse existing loop over CMakeLists.txt files - Optimise gentoo#2: If _CMAKE_MINREQVER_UNSUPPORTED is already set, then no further _cmake_minverreq-detect is necessary since we currently throw away the info on affected files - Relegate "CMake 4 detected; ..." to be a non-QA Notice, it is just an addendum Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
a17r
added a commit
that referenced
this pull request
Jun 13, 2025
- _cmake_minverreq-detect(): New function for reusability of regex - Optimise #1: Reuse existing loop over CMakeLists.txt files - Optimise gentoo#2: If _CMAKE_MINREQVER_UNSUPPORTED is already set, then no further _cmake_minverreq-detect is necessary since we currently throw away the info on affected files - Relegate "CMake 4 detected; ..." to be a non-QA Notice, it is just an addendum Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
a17r
added a commit
that referenced
this pull request
Jun 13, 2025
- _cmake_minverreq-detect(): New function for reusability of regex - Optimise #1: Reuse existing loop over CMakeLists.txt files - Optimise gentoo#2: If _CMAKE_MINREQVER_UNSUPPORTED is already set, then no further _cmake_minverreq-detect is necessary since we currently throw away the info on affected files - Relegate "CMake 4 detected; ..." to be a non-QA Notice, it is just an addendum Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
a17r
added a commit
that referenced
this pull request
Jun 13, 2025
- _cmake_minverreq-detect(): New function for reusability of regex - Optimise #1: Reuse existing loop over CMakeLists.txt files - Optimise gentoo#2: If _CMAKE_MINREQVER_UNSUPPORTED is already set, then no further _cmake_minverreq-detect is necessary since we currently throw away the info on affected files - Relegate "CMake 4 detected; ..." to be a non-QA Notice, it is just an addendum Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
a17r
added a commit
that referenced
this pull request
Jun 14, 2025
- _cmake_minverreq-lt(): New function for reusability of regex - Optimise #1: Reuse existing loop over CMakeLists.txt files - Optimise gentoo#2: If _CMAKE_MINREQVER_UNSUPPORTED is already set, then no further run of _cmake_minverreq-lt is necessary since we currently throw away the info on affected files - Relegate "CMake 4 detected; ..." to be a non-QA Notice, it is just an addendum Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michał Górny mgorny@gentoo.org