8000 Some fixes and cleanup by abbadon1334 · Pull Request #29 · atk4/audit · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Some fixes and cleanup #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkSide666 merged 12 commits into from
May 14, 2020
Merged

Some fixes and cleanup #29

merged 12 commits into from
May 14, 2020

Conversation

abbadon1334
Copy link
Collaborator

not too much to said only a cleanup.

@abbadon1334 abbadon1334 requested a review from DarkSide666 May 12, 2020 21:57
@codecov
Copy link
codecov bot commented May 12, 2020

Codecov Report

Merging #29 into develop will increase coverage by 4.52%.
The diff coverage is 64.42%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #29      +/-   ##
=============================================
+ Coverage      57.48%   62.00%   +4.52%     
- Complexity       109      112       +3     
=============================================
  Files              5        5              
  Lines            254      279      +25     
=============================================
+ Hits             146      173      +27     
+ Misses           108      106       -2     
Impacted Files Coverage Δ Complexity Δ
src/view/CommentForm.php 0.00% <0.00%> (ø) 2.00 <2.00> (ø)
src/view/History.php 0.00% <0.00%> (ø) 5.00 <5.00> (ø)
src/view/Lister.php 0.00% <0.00%> (ø) 22.00 <2.00> (+1.00)
src/Controller.php 88.67% <88.40%> (+3.60%) 71.00 <69.00> (+2.00)
src/model/AuditLog.php 68.08% <100.00%> (ø) 12.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d617567...42b6d7b. Read the comment docs.

Copy link
Member
@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@DarkSide666 DarkSide666 merged commit 702427b into develop May 14, 2020
@DarkSide666 DarkSide666 deleted the general-fixes branch May 14, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0