8000 Rename `Form::setModel()` method to `Form::setEntity()` by mvorisek · Pull Request #2239 · atk4/ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename Form::setModel() method to Form::setEntity() #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Jan 6, 2025
Merged

Rename Form::setModel() method to Form::setEntity() #2239

merged 28 commits into from
Jan 6, 2025

Conversation

mvorisek
Copy link
Member
@mvorisek mvorisek commented Jan 3, 2025 •
edited
Loading

continue #2192

mainly for Form class, but also for Card, CardSection, CardTable, Form\AbstractLayout and InlineEdit classes

and remove $model/$entity properties from View

@mvorisek mvorisek added the MAJOR label Jan 3, 2025
@mvorisek mvorisek force-pushed the form_setEntity branch 6 times, most recently from 54f9db6 to 0511b82 Compare January 5, 2025 17:09
@mvorisek mvorisek marked this pull request as ready for review January 5, 2025 19:12
@mvorisek mvorisek force-pushed the form_setEntity branch 4 times, most recently from c6921b6 to 2c0fab0 Compare January 5, 2025 20:24
DarkSide666
DarkSide666 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member
@DarkSide666 DarkSide666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
8000

@mvorisek mvorisek merged commit a8e4d3a into develop Jan 6, 2025
49 checks passed
@mvorisek mvorisek deleted the form_setEntity branch January 6, 2025 12:29
@mvorisek mvorisek mentioned this pull request Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkSide666 DarkSide666 DarkSide666 approved these changes

@romaninsh romaninsh Awaiting requested review from romaninsh

@ibelar ibelar Awaiting requested review from ibelar

@abbadon1334 abbadon1334 Awaiting requested review from abba 605C don1334

@georgehristov georgehristov Awaiting requested review from georgehristov

@acicovic acicovic Awaiting requested review from acicovic

@mkrecek234 mkrecek234 Awaiting requested review from mkrecek234

@PhilippGrashoff PhilippGrashoff Awaiting requested review from PhilippGrashoff

Assignees
No one assigned
Labels
MAJOR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @DarkSide666
0