Allow disabling dropdown clearable #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
reviewed
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
43A0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a small if to check if the "clearable" option is set, if it is then override the default model-based behaviour for dropdowns.
The current implementation requires you to actually use a model to populate the dropdown otherwise clearable is always set. In cases where you aren't using any models at all for DB/data related handling this will make it possible to delete the value which might not be the expected result.
This PR will make the the Dropdown honour setDropdownOption('clearable', false).