This repository was archived by the owner on Mar 3, 2023. It is now read-only.
If protocol handler set to never, unregister it on Windows #16521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryMuse
reviewed
Jan 9, 2018
| if (process.platform === 'win32') { | ||
| // Only win32 supports deregistration | ||
| const Registry = require('winreg') | ||
| const commandKey = new Registry({hive: 'HKCR', key: `\\atom`}) |
There was a problem hiding this comment.
Will the protocol client definitely be the only thing in this location?
There was a problem hiding this comment.
Yeah, all our other registry things live under HKCU (current user). You can see them in WinShell.js
|
@damieng Looks like |
added 2 commits
January 9, 2018 11:52
|
Merging with 1 failure, a known flake on appveyor. |
BinaryMuse
pushed a commit
that referenced
this pull request
Jan 9, 2018
…-to-never-on-startup If protocol handler set to never, unregister it on Windows (cherry picked from commit 5748f23)
BinaryMuse
pushed a commit
that referenced
this pull request
Jan 9, 2018
…-to-never-on-startup If protocol handler set to never, unregister it on Windows (cherry picked from commit 5748f23)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should remove the protocol handler if never is set however the electron unregister does not appear to work so blow away the registry key instead. This is only possible on Windows.