10000 Don't share overlayDimensions across instances by nathansobo · Pull Request #12977 · atom/atom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Don't share overlayDimensions across instances #12977

Merged
merged 1 commit into from
Oct 14, 2016
Merged

Don't share overlayDimensions across instances #12977

merged 1 commit into from
Oct 14, 2016

Conversation

nathansobo
Copy link
Contributor
@nathansobo nathansobo commented Oct 14, 2016 •
edited
Loading

Relates to #8295

Thanks to @matthewwithanm for finding this error. @matthewwithanm do you think this definitively closes that issue?

@Ben3eeE would you mind testing this out and see if the behavior is improved in that one flickering case you found dragging panes?

cc @lee-dohm

@matthewwithanm
Copy link
Contributor

@nathansobo!! Thanks for such a quick turnaround on this 😊

I can't say for certain if it's a definitive fix for #8295, but it does fix the situation that I was able to repro!

@nathansobo
Copy link
Contributor Author

but it does fix the situation that I was able to repro!

I'm going to be optimistic then...

Closes #8295

@nathansobo nathansobo merged commit fb1cf82 into master Oct 14, 2016
@nathansobo nathansobo deleted the ns-dont-share-overlay-dimensions branch October 14, 2016 05:11
@nathansobo
Copy link
Contributor Author

Thanks again for tracking this down. Pretty embarrassing but I'm happy to have your team on our side! ❤️ ⚡

@nathansobo nathansobo mentioned this pull request Oct 14, 2016
Closed
@Ben3eeE
Copy link
Contributor
Ben3eeE commented Oct 14, 2016

Thanks for the summon. This does seem to fix the problem.

Thanks @nathansobo

This was referenced Oct 14, 2016
Closed
Closed
@jeremyfa
Copy link

Man, I wake up this morning and see this wonderful merge! This is the most annoying issue I am experiencing with atom, I need to test this right now from git and will tell you if it worked. And let's be optimistic yes 👍

@jeremyfa
Copy link

The fix seems to work :D ! Thanks a lot for the efforts ❤️

@Ben3eeE
Copy link
Contributor
Ben3eeE commented Oct 14, 2016

@jeremyfa Awesome to hear! Thanks for testing it out and reporting back 🙇‍♂️

@ypresto
Copy link
Contributor
ypresto commented Oct 15, 2016

Wow great work...!!! Thanks a lot!!

maxbrunsfeld pushed a commit that referenced this pull request Oct 17, 2016
@maxbrunsfeld
Merge pull request #12977 from atom/ns-dont-share-overlay-dimensions
0ecc150 
Don't share overlayDimensions across instances
nathansobo pushed a commit that referenced this pull request Oct 18, 2016
Merge pull request #12977 from atom/ns-dont-share-overlay-dimensions
bd4040b 
Don't share overlayDimensions across instances
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3A2D
5 participants
@nathansobo @matthewwithanm @Ben3eeE @jeremyfa @ypresto
0