8000 Upgrade apm to 2.5.0 by smashwilson · Pull Request #20703 · atom/atom · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Upgrade apm to 2.5.0 #20703

Merged
merged 1 commit into from
May 7, 2020
Merged

Upgrade apm to 2.5.0 #20703

merged 1 commit into from
May 7, 2020

Conversation

smashwilson
Copy link
Contributor

No description provided.

@DeeDeeG
Copy link
Contributor
DeeDeeG commented May 6, 2020 •
edited
Loading

Hi again!

I noticed the CI failure is a simple timeout (when the CI environment tried to do apt install during its setup on Linux). I expect it would pass if re-started.

This change nearly makes Atom fully build-able with Python 3. Wanted to mention that (alongside updating apm in this repo), updating npm in scripts/package[-lock].json to 6.12.0 or later would make Atom fully build-able with Python 3! (Might be good to also adjust dependencies in the .deb and .rpm packaging. Since Debian/Ubuntu are planning to not ship Python 2 in their next releases.)

I already tried this (see my comment in #20585, and my proof of concept branch), and it worked.

P.S. I would volunteer to do any of this follow-up work if it would be helpful. (I like to use the dev branches of Ubuntu, and this is a blocker for using Atom in the development branch of Ubuntu 20.10 Groovy Gorilla.)

@smashwilson
Copy link
Contributor Author

I expect it would pass if re-started.

Me too, but I can't seem to log in to Azure DevOps to actually restart it 🙈 I'll give it another shot later I suppose, if nobody beats me to it!

@smashwilson smashwilson merged commit 49f73af into master May 7, 2020
@smashwilson smashwilson deleted the apm-up branch May 7, 2020 11:51
This was referenced May 7, 2020
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smashwilson @DeeDeeG
0