This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Speed up blinking cursor #22354
Merged
Speed up blinking cursor #22354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just make it configurable? EDIT: Oh, I just saw the branch's name. Why? What does this fix? |
|
@ThatXliner This spec has been very flaky on CI. https://github.com/atom/atom/blob/flaky-blinking-cursor-spec/spec/text-editor-component-spec.js#L635-L637. This PR mitigates the flakiness. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase blinking cursor period on spec to mitigate flakiness on CI.