Add zlib:compress/1 #1570
Merged
Add zlib:compress/1 #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a8ee68 to
55d0eaf
Compare
36 tasks
bettio
requested changes
Mar 14, 2025
src/libAtomVM/nifs.c
Outdated
| @@ -2411,59 +2421,69 @@ static term nif_erlang_float_to_list(Context *ctx, int argc, term argv[]) | |||
| return make_list_from_ascii_buf((uint8_t *) float_buf, len, ctx); | |||
| } | |||
|
|
|||
| static term nif_erlang_list_to_binary_1(Context *ctx, int argc, term argv[]) | |||
| static term list_to_binary(term list, term *ret, Context *ctx) | |||
There was a problem hiding this comment.
If we want to keep this approach I really suggest renaming this function to something like: list_to_binary_maybe_gc so the caller will be aware about the fact that after a call to this function, any non trivial term will be invalid.
There was a problem hiding this comment.
I moved only part of this function in the end. It doesn't alloc on erl-heap.
bettio
reviewed
Mar 15, 2025
55d0eaf to
602637e
Compare
bettio
requested changes
Jun 18, 2025
https://www.erlang.org/doc/apps/erts/zlib.html#compress/1 Signed-off-by: Jakub Gonet <jakub.gonet@swmansion.com>
Code in folding functions casted avm_int_t to char, silently truncating input. Now we check if the value fits in the char and fail operation if not. Signed-off-by: Jakub Gonet <jakub.gonet@swmansion.com>
dbd7c37 to
b7745b4
Compare
bettio
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.erlang.org/doc/apps/erts/zlib.html#compress/1
Fixes #1632.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later