Fix PHP 8.1 return type deprecation errors #865
Conversation
|
I think my first proposal is not correct, as it may break classes that extends modified classes. Indeed, their method signature may differ and it will result in a fatal error. I propose to use the |
|
Honestly, it's why I need time to check it ;) Using a two steps process, could indeed be the right path to make it properly done. If you see some other element to break feel free to prepare it for a V5 ;) |
|
I've updated this PR to prevent BR breaks. Explicit return types will be required for PHP 9.0 compatibility, so it can be done later :). |
|
Hi @cedric-anne, |
|
Hi @villfa I think all of them are fixed now. I executed this simple script in atoum roor dir to detect them: spl_autoload_register(
function ($class) {
if (!preg_match('/^atoum\\\\/', $class)) {
return;
}
include 'classes/' . implode('/', explode('\\', preg_replace('/^atoum\\\\atoum\\\\/', '', $class))) . '.php';
}
);
$dir_iterator = new RecursiveIteratorIterator(
new RecursiveDirectoryIterator(__DIR__ . '/classes'),
RecursiveIteratorIterator::SELF_FIRST
);
foreach ($dir_iterator as $file) {
if ($file->getExtension() !== 'php') {
continue;
}
require_once $file->getRealPath();
} |
Segfault is still present :/. |
Fixes
ArrayAccess,CountableandIteratorAggregateimplementations.It removes the fluent logic on
ArrayAccessimplementations, so it may introduce BC breaks.