8000 fix: typo by c-git · Pull Request #1741 · atuinsh/atuin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: typo #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: typo #1741

merged 1 commit into from
Feb 20, 2024

Conversation

c-git
Copy link
Contributor
@c-git c-git commented Feb 20, 2024

Fixes a small typo

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@c-git
Copy link
Contributor Author
c-git commented Feb 20, 2024

I just realized it might just be the the setting is actually spelled that way and isn't wrong. I didn't actually test just noticed the underline in vscode.

@akinomyoga
Copy link
Contributor
akinomyoga commented Feb 20, 2024

It's my fault. edit: It should be just a typo unless I made exactly the same typo in the actual code, which is unlikely. edit2: I confirmed:

$ git grep underilne
atuin-client/config.toml:## "{blink,steady}-{block,underilne,bar}".
$ git grep underline
atuin-client/src/settings.rs:    #[serde(rename = "blink-underline")]
atuin-client/src/settings.rs:    #[serde(rename = "steady-underline")]

@ellie
Copy link
Member
ellie commented Feb 20, 2024

Thank you! Speedy review there @akinomyoga, thank you 🥳

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

@ellie ellie merged commit 409456f into atuinsh:main Feb 20, 2024
@c-git c-git deleted the patch-1 branch February 20, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0