Add serial support for HiFive Premier P550 #443
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan-Velickovic <i.velickovic@unsw.edu.au>
Signed-off-by: Ivan-Velickovic <i.velickovic@unsw.edu.au>
Signed-off-by: Ivan-Velickovic <i.velickovic@unsw.edu.au>
307d4d7 to
0d176ab
Compare
|
Hmm this used to work but it looks like something broke/changed in the process of rebasing. Now I only get debug printing and nothing out via the UART driver. |
midnightveil
reviewed
Jul 1, 2025
| @@ -96,6 +92,9 @@ static void set_baud(unsigned long baud) | |||
| /* Divisor Latch Access Bit (DLAB) of the LCR must be set. | |||
| * These registers share their address with the FIFO's. | |||
| */ | |||
| #if UART_DW_APB_SHADOW_REGISTERS | |||
| while (*REG_PTR(UART_USR) & 0x1); | |||
There was a problem hiding this comment.
Was adding this intentional?
That might cause it to hang
There was a problem hiding this comment.
This was done a while ago but from memory this was necessary and a bug in the current driver. I tried with and without this part of the patch but still nothing.
|
I can confirm that on 21b10b4 the serial example works. |
|
It seems that while we get into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.