GPIO Driver Class #387
Closed
GPIO Driver Class #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tristan Clinton-Muehr <tristocm@gmail.com>
… to multiple client channels, added logic for configuring a pin to an irq in the hardware registers
drivers/gpio/imx/gpio.c
Outdated
Comment on lines
37
to
48
| case IMX_GPIO_IRQ_AH_GPIO1_7: | ||
| microkit_irq_ack(ch); | ||
| microkit_notify(driver_to_client_channel_mappings[ch - IMX_GPIO_IRQ_CHANNEL_START]); | ||
| break; | ||
| case IMX_GPIO_IRQ_AH_GPIO1_6: | ||
| microkit_irq_ack(ch); | ||
| microkit_notify(driver_to_client_channel_mappings[ch - IMX_GPIO_IRQ_CHANNEL_START]); | ||
| break; | ||
| case IMX_GPIO_IRQ_AH_GPIO1_5: | ||
| microkit_irq_ack(ch); | ||
| microkit_notify(driver_to_client_channel_mappings[ch - IMX_GPIO_IRQ_CHANNEL_START]); | ||
| break; |
There was a problem hiding this comment.
Since the code in each is exactly the same, you can fold them into one case statement:
Suggested change
| case IMX_GPIO_IRQ_AH_GPIO1_7: | |
| microkit_irq_ack(ch); | |
| microkit_notify(driver_to_client_channel_mappings[ch - IMX_GPIO_IRQ_CHANNEL_START]); | |
| break; | |
| case IMX_GPIO_IRQ_AH_GPIO1_6: | |
| microkit_irq_ack(ch); | |
| microkit_notify(driver_to_client_channel_mappings[ch - IMX_GPIO_IRQ_CHANNEL_START]); | |
| break; | |
| case IMX_GPIO_IRQ_AH_GPIO1_5: | |
| microkit_irq_ack(ch); | |
| microkit_notify(driver_to_client_channel_mappings[ch - IMX_GPIO_IRQ_CHANNEL_START]); | |
| break; | |
| case IMX_GPIO_IRQ_AH_GPIO1_7: | |
| case IMX_GPIO_IRQ_AH_GPIO1_6: | |
| case IMX_GPIO_IRQ_AH_GPIO1_5: | |
| microkit_irq_ack(ch); | |
| microkit_notify(driver_to_client_channel_mappings[ch - IMX_GPIO_IRQ_CHANNEL_START]); | |
| break; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes: