feat: support relative path1 in join. #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @jods4 |
|
It might work in webpack if you don't use conventions in the plugin; or if you do a small tweak, see webpack-plugin#164. At least with webpack an alternative to dotting out of source is setting up aliases. |
This is to support aurelia.use.feature('../src') and aurelia.use.plugin('../../local-plugin/dist/native-modules') for easier local plugin development. To be fair, this doesn't work in cli-bundler as requirejs doesn't support moduleId starting in "../". This doesn't work in webpack either, but we probably can update aurelia-webpack-plugin PreserveModuleNamePlugin to support it. This feature improves dumber experience when developing Aurelia plugin locally. Well, we don't have official offering of skeleton for dumber, but I am planning to use this feature in https://github.com/dumberjs/new.
closes #27
|
@EisenbergEffect can you review this? This is a safe change. We can call this either feat or fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support
aurelia.use.feature('../src')andaurelia.use.plugin('../../local-plugin/dist/native-modules')for easier local plugin development. To be fair, this doesn't work in cli-bundler as requirejs doesn't support moduleId starting in "../". This doesn't work in webpack either, but we probably can update aurelia-webpack-plugin PreserveModuleNamePlugin to support it. This feature improves dumber experience when developing Aurelia plugin locally. Well, we don't have official offering of skeleton for dumber, but I am planning to use this feature in aurelia skeleton in https://github.com/dumberjs/new.