8000 [feat] GPU support by JieRen98 · Pull Request #309 · autodiff/autodiff · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[feat] GPU support #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 13, 2024
Merged

[feat] GPU support #309

merged 10 commits into from
Jan 13, 2024

Conversation

JieRen98
Copy link
Contributor
@JieRen98 JieRen98 commented Jan 7, 2024

No description provided.

@JieRen98
Copy link
Contributor Author
JieRen98 commented Jan 7, 2024

Dual is almost done, please check. Please consider applying for a GPU instance for testing cuda codes from GitHub Resources.

@JieRen98 JieRen98 mentioned this pull request Jan 7, 2024
@JieRen98
Copy link
Contributor Author
JieRen98 commented Jan 7, 2024

real is supported

@JieRen98
Copy link
Contributor Author
JieRen98 commented Jan 7, 2024

For me, I only need forward. In addition, reverse is not easy to implement because it uses make_shared.

@JieRen98
Copy link
Contributor Author
JieRen98 commented Jan 8, 2024

How to add cuda-toolkit to the test environment? Usually, I use conda install cuda-toolkit -c nvidia to install.

@allanleal
Copy link
Member

Hi @JieRen98 , thanks a lot for your contribution. Are you planning on more additions to this PR?

@JieRen98
Copy link
Contributor Author
JieRen98 commented Jan 8, 2024 via email

@JieRen98
Copy link
Contributor Author
JieRen98 commented Jan 8, 2024

CUDA compile options --expt-relaxed-constexpr --extended-lambda are necessary, I think we should also add them to the bazel configuration file.

@JieRen98
Copy link
Contributor Author
JieRen98 commented Jan 8, 2024

Workflows may need to change too.

@allanleal allanleal merged commit d97e7cf into autodiff:main Jan 13, 2024
yut23 added a commit to yut23/autodiff that referenced this pull request Feb 6, 2024
This also removes the hard dependency on Eigen introduced in PR autodiff#309, as
long as the user defines AUTODIFF_DEVICE_FUNC before including any
autodiff headers.
allanleal pushed a commit that referenced this pull request Feb 7, 2024
This also removes the hard dependency on Eigen introduced in PR #309, as
long as the user defines AUTODIFF_DEVICE_FUNC before including any
autodiff headers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0