Add pyasyncore dependency to satisfy issue #946 and #964 for use in Python 3.12.
#981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephj11
referenced
this pull request
Dec 8, 2024
It looks like asyncore was removed from stdlib in 3.12. So, in it's place there is a drop-in replacement called pyasyncore available at [simonrob/pyasyncore](https://github.com/simonrob/pyasyncore). That project advises new projects to make use of [asyncio](https://docs.python.org/3/library/asyncio.html) instead, but I assume that would be too big of a lift for the existing codebase here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve tox errors and make AutoKey compatible with Python 3.12. Original credit for this fix goes to @dlk3 in issue #946.