8000 Replace NotImplemented with NotImplementedError by akubera · Pull Request #5 · automerge/automerge-py · GitHub

More Web Proxy on the site http://driver.im/

Replace NotImplemented with NotImplementedError #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

akubera wants to merge 1 commit into automerge:main from akubera:main

akubera commented

This replaces uses of the singleton NotImplemented with the correct value of NotImplementedError which is the exception to be raised when functionality is not implemented, (vs the object NotImplemented, which is to be returned when implementing some binary operations).

Current implementation doing raise NotImplemented ends up raising TypeErrors, because NotImplemented is not an Exception.


          Replace NotImplemented with NotImplementedError

4dd8eb4

Author

akubera commented

ERROR: Could not find a version that satisfies the requirement automerge

I don't think that's a problem with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

0