8000 refactor: pydoll v2 by thalissonvs · Pull Request #132 · autoscrape-labs/pydoll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: pydoll v2 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 162 commits into from
Jun 8, 2025
Merged

refactor: pydoll v2 #132

merged 162 commits into from
Jun 8, 2025

Conversation

thalissonvs
Copy link
Member
@thalissonvs thalissonvs commented May 28, 2025 •
edited
Loading

Refactoring Pull Request

Refactoring Scope

All codebase

Description

This refactoring aims to facilitate future maintenance. The file structure was reorganized for better readability, and type hints were added to improve robustness.

API Changes

  • No changes to public API
  • Public API changed, but backward compatible
  • Breaking changes to public API

Testing Checklist

  • Existing tests updated
  • New tests added for previously uncovered cases
  • All tests pass
  • Code coverage maintained or improved

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a thorough self-review of the refactored code
  • I have commented my code, particularly in complex areas
  • I have updated documentation if needed
  • I have run poetry run task lint and fixed any issues
  • I have run poetry run task test and all tests pass
  • My commits follow the conventional commits style

@thalissonvs
refactor: refactor the InputCommands class to enhance clarity and s…
4eec595 
…implicity in its operations
@thalissonvs
refactor: rename insert_text to paste_text and remove unused files
7a6b291
@thalissonvs
refactor: move command files to the protocol directory for better str…
3e04c0d 
…ucture
@thalissonvs
refactor: refactor import paths to use the protocol submodule structure
70ba3f5
@thalissonvs
refactor: refactor element imports and remove deprecated element file
cc7c8fe
@thalissonvs
refactor: refactor browser modules to use the new chromium structure
9e1b6af
@thalissonvs
refactor: refactor BrowserType import to a common constants module
849623b
@thalissonvs
refactor: refactor connection imports and rename manager files for cl…
472bea7 
…arity
@thalissonvs
refactor: refactor browser command constants to use Command class type
8cce6ef
@thalissonvs
refactor: refactor command structures and introduce base CommandParam…
5d5090f 
…s class
@thalissonvs
feat: add response classes for browser window target retrieval
2faad4a
@thalissonvs
refactor: refactor command methods to specify response types in Brows…
12829a3 
…erCommands
@thalissonvs
refactor: refactor execute_command to use type annotations for clarity
5e18727
@thalissonvs
refactor: add command and response types for protocol implementation
fa38502
@thalissonvs
refactor: add browser command methods for version, permissions, and d…
00eab4f 
…ownloads
@thalissonvs
refactor: refactor imports for better organization and readability
13a6d7f
@thalissonvs
refactor: rename command and response modules for better clarity
a832393
@thalissonvs
refactor: refactor command structures for better organization and cla…
1a34edd 
…rity
@thalissonvs
refactor: remove unused enum imports and rename base_types module
4aecaae
@thalissonvs
refactor: add enums for window states, download behaviors, and permis…
7910ddd 
…sions
@thalissonvs
refactor: refactor fetch command templates to use Command class
280daa8
@thalissonvs
feat: add enums for cookie priorities, connection types, and encodings
a9b8ce9
@thalissonvs
refactor: refactor import statement for CommandParams module path
eaa4c48
@thalissonvs
refactor: refactor import and rename EnableParams to FetchEnableParams
c457935
@thalissonvs
feat: add network command types and parameters for cookie management
ea6f01f
@thalissonvs
feat: organize command types into structured imports and exports
25c459f
@thalissonvs
refactor: refactor import statements for consistency in response types
70b9b91
@thalissonvs
refactor: refactor import statements for better readability and struc…
d66c6c6 
…ture
@thalissonvs
feat: add TypedDict definitions for network response types
5fd8a85
@thalissonvs
refactor: refactor response imports and update __all__ definitions
4e8169e
thalissonvs

This comment was marked as resolved.

Sign in to view

@codecov Codecov
Copy link
codecov bot commented Jun 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.77532% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pydoll/browser/tab.py 94.33% 15 Missing ⚠️
pydoll/browser/interfaces.py 75.00% 5 Missing ⚠️
pydoll/browser/managers/browser_process_manager.py 84.21% 3 Missing ⚠️
pydoll/browser/chromium/base.py 98.85% 2 Missing ⚠️
pydoll/commands/dom_commands.py 99.65% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thalissonvs
Copy link
Member Author

@cleitonleonel I fixed the tests. Can you test the lib and try to find some bugs? It would help a lot

@cleitonleonel
Copy link
Collaborator

@cleitonleonel I fixed the tests. Can you test the lib and try to find some bugs? It would help a lot

Sure, bro, I'll do that.

thalissonvs added 11 commits June 7, 2025 19:03
@thalissonvs thalissonvs merged commit 0799695 into main Jun 8, 2025
11 checks passed
@thalissonvs thalissonvs deleted the refactor/v2 branch June 8, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleitonleonel cleitonleonel cleitonleonel left review comments

Assignees

@thalissonvs thalissonvs

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thalissonvs @cleitonleonel
0