10000 feat: support for py3.10 by yie1d · Pull Request #173 · autoscrape-labs/pydoll · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support for py3.10 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 21, 2025
Merged

feat: support for py3.10 #173

merged 5 commits into from
Jun 21, 2025

Conversation

yie1d
Copy link
Contributor
@yie1d yie1d commented Jun 20, 2025

Pull Request

Description

  • Add more Python versions to the tests in the workflow.
  • Add the typing_extensions dependency.
  • Change the import source for NotRequired and TypedDict.

Related Issue(s)

Resolves #172

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes, no API changes)
  • Performance improvement
  • Tests (adding missing tests or correcting existing tests)
  • Build or CI/CD related changes

How Has This Been Tested?

run tests in python3.10

poetry run task test

Testing Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass

Screenshots

Implementation Details

API Changes

Additional Info

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run poetry run task lint and fixed any issues
  • I have run poetry run task test and all tests pass
  • My commits follow the conventional commits style

Sorry, something went wrong.

yie1d added 3 commits June 20, 2025 10:17
@yie1d
build(deps): add typing_extensions and drop python 3.11 requirement
b517bf6 
- Add typing_extensions package to dependencies
- Lower python version requirement to3.10
- Update import statements across multiple files to use typing_extensions
@yie1d
ci: add Python 3.10 to GitHub Actions matrix
684bd58 
- Include Python 3.10 in the list of Python versions for CI tests- Ensure compatibility and testing across more Python versions
@yie1d
build(deps): update dependencies for python 3.10
ecd21cb 
- Update async-timeout to version 5.0.1 for python < 3.11
- Add exceptiongroup backport for python < 3.11
- Update typing-extensions dependency for various packages
- Add tomli dependency for python < 3.11
- Update python-versions to ^3.10 in metadata
@codecov Codecov
Copy link
codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@thalissonvs
Copy link
Member

Nice @yie1d, just need to resolve the conflicts now

yie1d added 2 commits June 21, 2025 15:00
@yie1d
Merge branch 'main' into feature/support_for_py3.10
f8bb2eb 
# Conflicts:
#	poetry.lock
#	pyproject.toml
@yie1d
build(deps): update dependencies for python 3.10
ccf3531 
- Update async-timeout to version 5.0.1 for python < 3.11
- Add exceptiongroup backport for python < 3.11
- Update typing-extensions dependency for various packages
- Add tomli dependency for python < 3.11
- Update python-versions to ^3.10 in metadata
@yie1d
Copy link
Contributor Author
yie1d commented Jun 21, 2025

Nice @yie1d, just need to resolve the conflicts now

Hi @thalissonvs , this branch has already been merged with the latest code from the main branch now.

@thalissonvs thalissonvs merged commit bb3db46 into autoscrape-labs:main Jun 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalissonvs thalissonvs thalissonvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support for python 3.10
2 participants
@yie1d @thalissonvs
0