8000 Externalize Identity server license by joostmeijles · Pull Request #149 · avivasolutionsnl/sitecore-docker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Externalize Identity server license #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joostmeijles
Copy link
Collaborator

No description provided.

-SiteName $Env:SITE_NAME `
-SqlCoreUser $Env:SQL_USER `
-SqlCorePassword $Env:SQL_SA_PASSWORD `
-SqlServer $Env:SQL_SERVER `
-PasswordRecoveryUrl http://$Env:SITE_NAME `
-AllowedCorsOrigins http://$Env:SITECORE_SITE_NAME `
-ClientSecret "SIF-Default"
-ClientSecret "SIF-Default" `
-Skip "StartAppPool", "StartWebsite"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to skip those two tasks?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not start with a dummy license, and start is not necessary during build.

</Serilog>
</Logging>
<Host>
<LicenseFilePath>C:/license/license.xml</LicenseFilePath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no other way to modify the contents of sitecorehost.xml instead of replacing the whole file? Can be hard to track custom changes when upgrading to newer Sitecore versions.

8000

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried modifying it using Powershell, but somehow that didn't want to work for me (e.g. its not the same as we do for JSON in other places).

If you know a way using PS I am happy to use it :).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it simple for now 😉

</Serilog>
</Logging>
<Host>
<LicenseFilePath>C:/license/license.xml</LicenseFilePath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it simple for now 😉

@joostmeijles joostmeijles merged commit 7b46a42 into avivasolutionsnl:master Sep 4, 2019
@joostmeijles joostmeijles deleted the external_id_license branch September 4, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0