-
Notifications
You must be signed in to change notification settings - Fork 24
Externalize Identity server license #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externalize Identity server license #149
Conversation
-SiteName $Env:SITE_NAME ` | ||
-SqlCoreUser $Env:SQL_USER ` | ||
-SqlCorePassword $Env:SQL_SA_PASSWORD ` | ||
-SqlServer $Env:SQL_SERVER ` | ||
-PasswordRecoveryUrl http://$Env:SITE_NAME ` | ||
-AllowedCorsOrigins http://$Env:SITECORE_SITE_NAME ` | ||
-ClientSecret "SIF-Default" | ||
-ClientSecret "SIF-Default" ` | ||
-Skip "StartAppPool", "StartWebsite" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to skip those two tasks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will not start with a dummy license, and start is not necessary during build.
</Serilog> | ||
</Logging> | ||
<Host> | ||
<LicenseFilePath>C:/license/license.xml</LicenseFilePath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no other way to modify the contents of sitecorehost.xml
instead of replacing the whole file? Can be hard to track custom changes when upgrading to newer Sitecore versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried modifying it using Powershell, but somehow that didn't want to work for me (e.g. its not the same as we do for JSON in other places).
If you know a way using PS I am happy to use it :).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it simple for now 😉
</Serilog> | ||
</Logging> | ||
<Host> | ||
<LicenseFilePath>C:/license/license.xml</LicenseFilePath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it simple for now 😉
9569225
to
b1187c9
Compare
No description provided.