Fix Redis image not being pushed #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Redis target to base build and add to list of names so the image is build/pushed.
joostmeijles
requested changes
Oct 3, 2019
example/xc/docker-compose.yml
Outdated
| @@ -89,7 +89,7 @@ services: | |||
| - solr | |||
|
|
|||
| redis: | |||
| image: "${IMAGE_PREFIX}redis:${TAG}" | |||
| image: "sitecore-base-redis:${TAG}" | |||
There was a problem hiding this comment.
{IMAGE_PREFIX} includes the repository, so this will not work.
New REPOSITORY environment variable added to example docker-compose files. Can be used to configure the Docker repository. README updated with Redis information and the new REPOSITORY variable.
joostmeijles
approved these changes
Oct 3, 2019
|
/azp run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move Redis target to base build and add to list of names so the image is build/pushed.