Add Audio Resource Views #585
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awcodes
requested changes
Mar 22, 2025
| @@ -28,6 +28,8 @@ class="overflow-hidden h-full w-auto border border-gray-300 rounded dark:border- | |||
| /> | |||
| @elseif (str($file['type'])->contains('video')) | |||
| <video controls src="{{ $file['url'] }}"></video> | |||
| @elseif (str($record->type)->contains('audio')) | |||
There was a problem hiding this comment.
This should be $file['type'] instead of $record->type
Comment on lines
+102
to
+104
| 'relative block w-full overflow-hidden border border-gray-300 rounded-lg shadow-sm dark:bg-gray-800 dark:border-gray-700 dark:text-white flex justify-center checkered' => ! str($item['type'])->contains('audio'), | ||
| 'relative block w-full border p-4 border-gray-300 rounded-lg shadow-sm dark:bg-gray-800 dark:border-gray-700 dark:text-white h-32 checkered' =>str($item['type'])->contains('audio'), | ||
| 'h-64' => ! str($item['type'])->contains('video') && !str($item['type'])->contains('audio'), |
There was a problem hiding this comment.
Please pull duplicated classes out so as to not repeat them.
There was a problem hiding this comment.
Not quite what I meant. :)
'relative block w-full border border-gray-300 rounded-lg shadow-sm checkered dark:bg-gray-800 dark:border-gray-700 dark:text-white',
'flex justify-center overflow-hidden' => ! str($item['type'])->contains('audio'),
'h-32 p-4' => str($item['type'])->contains('audio'),
panupongTk
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current views are missing audio representation to match the standard file uploader.