Add EC2 Instance Metadata to metrics sent to CW. (Custom Dimensions) #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changed readme * Feature/add dimension file (#2) * added non-interactive dimension_file creation * added prompt for dimensions file path * added dimensions metadata info pull * added dimensionsreader.py file and created get_dimensions method in readerutils.py * added info to configreader.py file & created _get_dimensions_path method * created _load_dimensions method * removed logger info code blocks * troubleshooting metadata grab * returning a list back from DimensionsReader * pulling dimnesions from config instead of vaule_list * returned dimensions from _build_metric_dimensions() * testing dimension name format * make sure that the first letter of the dimension is lowercase for metric pull & first letter is capitlized for AWS CW Metric * corrected dim for plugininstance * added more info to dimensions file and used urllib2 instead of subprocess for pulling dimensions * added logging if dimensions file is empty * added nondimension regex pattern * corrected regex match * testing non-interactive setup then switch to dimensions used * cleaned-up logging * Update README.md * cleanup for master * Summary: Added custom metadata EC2 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #10
Description of changes:
Added a feature where a user can specify in a dimension file the instance metadata that he/she wants to be pushed to aws cloudwatch along with the metric information. For example, a user can specify region, availability-zone, private-ip, instanceid, and more in the dimension file. In effect those attributes will be pushed along with the metric data to aws cloudwatch giving more clarity and information to the user about the particular metric(s).
Usage:
Create dimensions file in whatever location you want.
Recommended Path: /opt/collectd-plugins/cloudwatch/config/dimensions
Add Instance Dimensions to file:
Host
PrivateIp
InstanceId
Region
etc.
Run: Python setup.py
For more information on instance dimensions to be added: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-identity-documents.html
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.