docs: (eks-mcp-server) improve README guidance for using the sensitive data access flag #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e data access flag
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 82.58% 82.41% -0.18%
==========================================
Files 355 333 -22
Lines 23438 22213 -1225
Branches 3651 3541 -110
==========================================
- Hits 19357 18307 -1050
+ Misses 2950 2796 -154
+ Partials 1131 1110 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Added additional unit tests for k8s_apis since codecov/project was failing |
krokoko
approved these changes
Jun 12, 2025
tenzingsherpaa
pushed a commit
to tenzingsherpaa/mcp
that referenced
this pull request
Jun 18, 2025
…e data access flag (awslabs#567) * docs: (eks-mcp-server) improve README guidance for using the sensitive data access flag * remove trailing whitespaces * remove another trailing whitespace * add unit tests to pass codecov --------- Co-authored-by: Sarah Li <srhli@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
--allow-sensitive-data-accessto the example mcp configs in the Quickstart section--allow-sensitive-data-accessUser experience
Users didn't know what the flag actually enabled and only found out when tools were failing to be invoked. Agents can usually figure out how to enable it after, but this change makes the experience a bit more seamless.
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? N
RFC issue number: n/a
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.