-
Notifications
You must be signed in to change notification settings - Fork 467
docs(CONTRIBUTING): add a section on server categorization #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds guidance for categorizing new MCP servers in the root README and adjusts the Code of Conduct email formatting.
- Introduces a “Special README.md considerations” section in CONTRIBUTING.md
- Updates the Code of Conduct contact line to use angle brackets for the email
Comments suppressed due to low confidence (3)
CONTRIBUTING.md:31
- [nitpick] Consider removing the "./" prefix in the code span so it consistently reads
README.md
, matching other references in the docs.
### Special `./README.md` considerations for new MCP servers
CONTRIBUTING.md:33
- [nitpick] This line is very long; consider breaking it into multiple bullet points or wrapping at ~80 characters to improve readability.
When adding a new MCP server, you must update the README.md to include your server in the appropriate categories under "Browse by What You're Building" and "Browse by How You're Working" sections with a brief description that clearly explains its purpose. Include a link to the server's directory using the pattern `src/your-server-name/`. Ensure your server's description is consistent with the style of existing entries.
CONTRIBUTING.md:46
- Convert this to a Markdown mailto link for better usability, e.g.,
[opensource-codeofconduct@amazon.com](mailto:opensource-codeofconduct@amazon.com)
.
<opensource-codeofconduct@amazon.com> with any additional questions or comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 86.47% 86.34% -0.13%
==========================================
Files 360 350 -10
Lines 23866 23317 -549
Branches 3762 3694 -68
==========================================
- Hits 20637 20132 -505
+ Misses 2137 2106 -31
+ Partials 1092 1079 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or this link
Co-authored-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds a special consideration for server categorization in the root readme
Summary
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N)
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.