8000 docs(CONTRIBUTING): add a section on server categorization by theagenticguy · Pull Request #606 · awslabs/mcp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs(CONTRIBUTING): add a section on server categorization #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

theagenticguy
Copy link
Contributor
@theagenticguy theagenticguy commented Jun 17, 2025

Adds a special consideration for server categorization in the root readme

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@Copilot Copilot AI review requested due to automatic review settings June 17, 2025 00:12
@theagenticguy theagenticguy requested a review from a team as a code owner June 17, 2025 00:12
Copy link
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds guidance for categorizing new MCP servers in the root README and adjusts the Code of Conduct email formatting.

  • Introduces a “Special README.md considerations” section in CONTRIBUTING.md
  • Updates the Code of Conduct contact line to use angle brackets for the email
Comments suppressed due to low confidence (3)

CONTRIBUTING.md:31

  • [nitpick] Consider removing the "./" prefix in the code span so it consistently reads README.md, matching other references in the docs.
### Special `./README.md` considerations for new MCP servers

CONTRIBUTING.md:33

  • [nitpick] This line is very long; consider breaking it into multiple bullet points or wrapping at ~80 characters to improve readability.
When adding a new MCP server, you must update the README.md to include your server in the appropriate categories under "Browse by What You're Building" and "Browse by How You're Working" sections with a brief description that clearly explains its purpose. Include a link to the server's directory using the pattern `src/your-server-name/`. Ensure your server's description is consistent with the style of existing entries.

CONTRIBUTING.md:46

  • Convert this to a Markdown mailto link for better usability, e.g., [opensource-codeofconduct@amazon.com](mailto:opensource-codeofconduct@amazon.com).
<opensource-codeofconduct@amazon.com> with any additional questions or comments.

Copy link
codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (08b09a5) to head (40c71aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   86.47%   86.34%   -0.13%     
==========================================
  Files         360      350      -10     
  Lines       23866    23317     -549     
  Branches     3762     3694      -68     
==========================================
- Hits        20637    20132     -505     
+ Misses       2137     2106      -31     
+ Partials     1092     1079      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member
@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or this link

Co-authored-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
Copy link
Member
@scottschreckengaust scottschreckengaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexa-perlov alexa-perlov added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit 1a8879e Jun 17, 2025
144 checks passed
@alexa-perlov alexa-perlov deleted the docs/contributing branch June 17, 2025 00:45
@rshevchuk-git rshevchuk-git mentioned this pull request Jun 19, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0