8000 Add `sr-only` for screenreaders by brennanangel · Pull Request #27 · awssat/tailwindo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add sr-only for screenreaders #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2020
Merged

Add sr-only for screenreaders #27

merged 1 commit into from
Jul 30, 2020

Conversation

brennanangel
Copy link
Contributor

fixes #26

Tailwindcss and Bootstrap have the same usage of this class so we should keep it during conversion.

Bootstrap's Mixin: https://github.com/twbs/bootstrap/blob/main/scss/mixins/_screen-reader.scss

  position: absolute;
  width: 1px;
  height: 1px;
  padding: 0;
  margin: -1px; 
  overflow: hidden;
  clip: rect(0, 0, 0, 0);
  white-space: nowrap;
  border: 0;

Tailwind: https://tailwindcss.com/docs/screen-readers/

position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
clip: rect(0, 0, 0, 0);
white-space: nowrap;
border-width: 0;

@brennanangel
Add sr-only for screenreaders
3dee9e4 
fixes awssat#26 

Tailwindcss and Bootstrap have the same usage of this class so we should keep it during conversion.

Bootstrap's Mixin: https://github.com/twbs/bootstrap/blob/main/scss/mixins/_screen-reader.scss
```
  position: absolute;
  width: 1px;
  height: 1px;
  padding: 0;
  margin: -1px; 
  overflow: hidden;
  clip: rect(0, 0, 0, 0);
  white-space: nowrap;
  border: 0;
```

Tailwind: https://tailwindcss.com/docs/screen-readers/
```
position: absolute;
width: 1px;
height: 1px;
padding: 0;
margin: -1px;
overflow: hidden;
clip: rect(0, 0, 0, 0);
white-space: nowrap;
border-width: 0;
```
@abdumu abdumu merged commit 20e7072 into awssat:master Jul 30, 2020
@abdumu
Copy link
Member
abdumu commented Jul 30, 2020

thanks

@brennanangel brennanangel deleted the patch-1 branch July 30, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sr-only accidentally removed
2 participants
@brennanangel @abdumu
0