aya,aya-obj: expose run_time_ns & run_cnt fields, and add bpf_enable_stats util function #959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
6f05b4a to
24c4e05
Compare
|
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
24c4e05 to
2fbab8c
Compare
2fd8493 to
b8c2d3d
Compare
b8c2d3d to
fcb349d
Compare
ab96ee7 to
2105541
Compare
6eedb59 to
389a267
Compare
dave-tucker
reviewed
Jul 11, 2024
dave-tucker
requested changes
Jul 11, 2024
aya-obj/src/stats.rs
Outdated
| RunTime, | ||
| } | ||
|
|
||
| impl From<BpfStatsType> for bpf_stats_type { |
There was a problem hiding this comment.
Given there's only one possible value here (BPF_STATS_RUN_TIME) do we need this?
There was a problem hiding this comment.
I included a idiomatic Rust wrapper for bpf_enable_stats when I initially had enable_stats param require the type.
I understand that aya-obj is meant for object parsing. Does it also function as a "rusty" API for the FFI? If not, then I suppose enable_stats can directly use bpf_stats_type::BPF_STATS_RUN_TIME.
tyrone-wu
added a commit
to tyrone-wu/aya
that referenced
this pull request
Jul 12, 2024
Added `bpf_stats_type` enum to codegen bindings. Refs: aya-rs#959
|
@tyrone-wu, this pull request is now in conflict and requires a rebase. |
389a267 to
a73ed77
Compare
e550973 to
f08141c
Compare
dave-tucker
approved these changes
Jul 22, 2024
vadorovsky
approved these changes
Jul 25, 2024
038c465 to
55d57ad
Compare
alessandrod
reviewed
Aug 14, 2024
55d57ad to
8b7ee9a
Compare
8b7ee9a to
a759a68
Compare
Add bpf syscall function for BPF_ENABLE_STATS to enable stats tracking for benchmarking purposes. Additionally, move `#[cfg(test)]` annotation around the `Drop` trait instead. Having separate functions causes some complications when needing ownership/moving of the inner value `OwnedFd` when `Drop` is manually implemented.
Added functions to expose `run_time_ns` & `run_cnt` statistics from ProgramInfo/bpf_prog_info.
a759a68 to
a25f501
Compare
alessandrod
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
run_time_ns&run_cntfields inProgramInfo.BPF_ENABLE_STATSsyscall command that returns a file descriptor of the handler.- [ ] Maybe? Add another util function for enabling runtime stats through sysctl procfs sinceBPF_ENABLE_STATSis a kernel 5.8+ feature.These can be used for monitoring/benchmarking runtime statistics for programs. The
BPF_ENABLE_STATSbpf command can be used in conjunction withBPF_OBJ_GET_INFO_BY_FDto monitor therun_time_ns&run_cntfields.More on it can be found in https://lore.kernel.org/bpf/20200430071506.1408910-2-songliubraving@fb.com/.