8000 fix: streamline OpenNextjs prebuild execution by removing conditional checks for production by jcbsfilho · Pull Request #181 · aziontech/lib · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: streamline OpenNextjs prebuild execution by removing conditional checks for production #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

jcbsfilho
Copy link
Collaborator

This pull request simplifies the prebuild function in the OpenNextjs preset by removing unnecessary conditionals and ensuring all relevant commands are executed unconditionally.

Simplification of prebuild logic:

  • Removed conditional checks (ctx.production and ctx.skipFrameworkBuild) around the execution of build, populateAssets, and populateCache commands. These commands are now executed unconditionally to streamline the build process. ([packages/presets/src/presets/opennextjs/prebuild.tsL30-L54](https://github.com/aziontech/lib/pull/181/files#diff-352f0e083b1ae2982427afec2ed79c7bd108b94a5f8a703db8aac284b33632f6L30-L54))

Copy link
@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

@jcbsfilho jcbsfilho merged commit 8d513d9 into stage Jun 24, 2025
2 checks passed
@jcbsfilho jcbsfilho deleted the fix/preset-opennextjs branch June 24, 2025 17:31
jotanarciso pushed a commit that referenced this pull request Jun 24, 2025
[skip ci]
## [1.20.0-stage.17](v1.20.0-stage.16...v1.20.0-stage.17) (2025-06-24)

### Bug Fixes

* streamline OpenNextjs prebuild execution by removing conditional checks for production (#181) ([8d513d9](8d513d9))
@jotanarciso
Copy link
Collaborator

🎉 This PR is included in version 1.20.0-stage.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

jotanarciso pushed a commit that referenced this pull request Jun 25, 2025
[skip ci]
## [1.20.0](v1.19.1...v1.20.0) (2025-06-25)

### Features

* add OpenNextjs preset (#179) ([ca726ad](ca726ad))
* add type safety for storage edge_access parameter ([a450f78](a450f78))
* **config:** azion api v4 (#161) ([49c3f02](49c3f02))
* purge api v4 (#167) ([f779d6a](f779d6a))
* upgrade unenv 1.x to 2.x (#159) ([60ef725](60ef725))

### Bug Fixes

* add Azion.Storage to globalThis for polyfill (#163) ([cd659db](cd659db))
* add polyfill for clearInterval and update injection in unenv preset (#172) ([ea99874](ea99874))
* api v4  (#168) ([dc33e5a](dc33e5a))
* polyfills for Node.js compatibility (#170) ([329f4c4](329f4c4))
* **presets:** add missing prebuild command in preact preset ([8674785](8674785))
* **presets:** astro prebuild ([846990f](846990f))
* **preset:** update ruleset of html preset ([90b0def](90b0def))
* rename skipProjectBuild to skipFrameworkBuild in BuildContext (#180) ([5252f0a](5252f0a))
* revert exported name (presets) ([94a1739](94a1739))
* rm worker property ([8673494](8673494))
* streamline OpenNextjs prebuild execution by removing conditional checks for production (#181) ([8d513d9](8d513d9))
* streamline stream polyfills and enhance process, module, setInterval (#169) ([118f7bb](118f7bb))
* wasm-image-processor resize wrapper (#164) ([a02d941](a02d941))

### Reverts

* api v4  (#176) ([e93e073](e93e073))
@jotanarciso
Copy link
Collaborator

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

< 8F18 ul dir="auto">
  • npm package (@latest dist-tag)
  • GitHub release
  • Your semantic-release bot 📦🚀

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Development

    Successfully merging this pull request may close these issues.

    2 participants
    0