fix: キーボード表示screenのサイズ決定ロジックを見直し、安定したサイズ変更を可能に #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3fe6952 to
ab5363f
Compare
Closed
|
@nyanko3141592 に確認もらって #483 も直ってるのを確認 |
|
#489 はTestFlightの上で確認をお願いする |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #478
Fix #483
LayoutConstraint周りの処理を丁寧に検討した結果、いくつかのバグや不本意の実装を修正できた。
reloadAllViewという険しい処理（全ビューの再起動）を行わなければならなかったが、この変更により非常に安定して実施できるようになったviewDisappearの後にviewDidLoadが呼ばれずにキーボードが再表示されるため、キーボードが表示されなかった。この問題をviewWillLoadのタイミングでチェックをいれることで修正した