8000 Not required by SukritBhatt · Pull Request #1320 · abiosoft/colima · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Not required #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SukritBhatt
Copy link
Contributor
@SukritBhatt SukritBhatt commented May 12, 2025

This is being replaced by #1324

Currently, the second prompt for the delete command uses a bold + red format mode using escape codes. However, this mode is not reset at the end and ends up leaking unto next lines on the terminal.

This change will make sure all `question` strings passed to the `Prompt` function will be closed properly by a reset escape sequence.

Includes a fmt change too.
@SukritBhatt SukritBhatt force-pushed the properly-close-formatting-mode branch from 5f480db to 8ab866c Compare May 12, 2025 18:28
@SukritBhatt SukritBhatt marked this pull request as draft May 12, 2025 18:43
@SukritBhatt SukritBhatt marked this pull request as ready for review May 12, 2025 19:38
@SukritBhatt SukritBhatt deleted the properly-close-formatting-mode branch May 12, 2025 19:42
@SukritBhatt SukritBhatt restored the properly-close-formatting-mode branch May 12, 2025 19:55
@SukritBhatt SukritBhatt reopened this May 12, 2025
@SukritBhatt SukritBhatt changed the title Reset formatting modes at the end of delete prompt null May 21, 2025
@SukritBhatt SukritBhatt changed the title null Not required May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0