8000 minor fix: load env for GitHub DataSource by keshav-space · Pull Request #1118 · aboutcode-org/vulnerablecode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

minor fix: load env for GitHub DataSource #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

minor fix: load env for GitHub DataSource #1118

merged 1 commit into from
Feb 22, 2023

Conversation

keshav-space
Copy link
Member
  • DataSource must load env variable before accessing it
  • Skip empty version constraints in GitLab advisory

Signed-off-by: Keshav Priyadarshi git@keshav.space

@keshav-space keshav-space added the VulnTotal Tool for cross-validating vulnerability label Feb 7, 2023
Hritik14
Hritik14 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Collaborator
@Hritik14 Hritik14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keshav-space
load env for GitHub DataSource
2089876 
- DataSource must load env variable before accessing it
- Skip empty version constraints in GitLab advisory

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
8441
@keshav-space keshav-space merged commit d0aba20 into aboutcode-org:main Feb 22, 2023
@keshav-space keshav-space deleted the vulntotal branch February 22, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hritik14 Hritik14 Hritik14 approved these changes

@pombredanne pombredanne Awaiting requested review from pombredanne

@TG1999 TG1999 Awaiting requested review from TG1999

Assignees
No one assigned
Labels
VulnTotal Tool for cross-validating vulnerability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keshav-space @Hritik14
0