8000 Add support for conan advisories by TG1999 · Pull Request #1155 · aboutcode-org/vulnerablecode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add support for conan advisories #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2023
Merged

Add support for conan advisories #1155

merged 4 commits into from
Mar 29, 2023

Conversation

TG1999
Copy link
Contributor
@TG1999 TG1999 commented Mar 21, 2023

No description provided.

@TG1999 TG1999 force-pushed the add_conan branch 4 times, most recently from e6d9e61 to 8e09aaa Compare March 27, 2023 14:18
pombredanne
pombredanne requested changes Mar 28, 2023
View reviewed changes
Copy link
Member
@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... See a nit inlined and you need to add a CHANGELOG entry too!

vulnerabilities/package_managers.py Outdated
@@ -556,6 +556,22 @@ def fetch(self, pkg: str) -> Iterable[PackageVersion]:
)


class ConanVersionAPI(VersionAPI):
"""
Fetch versions of Erlang packages from the hex API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erlang and hex?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

TG1999 added 4 commits March 28, 2023 18:19
@TG1999
Add support for conan advisories
a224720 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Add conan package manager API
aca0a86 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Adjust tests according to latest univers changes
a81ae30 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Address review comments
45f1fe2 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
pombredanne
pombredanne approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member
@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@TG1999 TG1999 merged commit 20a88ef into aboutcode-org:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

@johnmhoran johnmhoran Awaiting requested review from johnmhoran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TG1999 @pombredanne
0