8000 Fix Encoding Type in Fireeye Importer by harsh098 · Pull Request #1404 · aboutcode-org/vulnerablecode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Encoding Type in Fireeye Importer #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 25, 2024
Merged

Fix Encoding Type in Fireeye Importer #1404

merged 4 commits into from
Jan 25, 2024

Conversation

harsh098
Copy link
Contributor

This PR fixes issue #1403

@harsh098
Fix Encoding Type in Fireeye Importer
4dd005f 
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
@harsh098 harsh098 mentioned this pull request Jan 25, 2024
Closed
TG1999
TG1999 requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor
@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for verifying the code change :)

@harsh098 harsh098 mentioned this pull request Jan 25, 2024
Closed
@harsh098
Add Test to Fireeye Importer
974cd84 
This test checks for UTF-8-SIG encoding

Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
@harsh098
Reformat test_fireeye.py
a361856 
Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
TG1999
TG1999 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor
@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TG1999 TG1999 merged commit 2471c87 into aboutcode-org:main Jan 25, 2024
TG1999 added a commit to TG1999/vulnerablecode that referenced this pull request Jul 19, 2024
@harsh098 @TG1999
Fix Encoding Type in Fireeye Importer (aboutcode-org#1404)
1291daa 
* Fix Encoding Type in Fireeye Importer

Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>

* Add Test to Fireeye Importer

This test checks for UTF-8-SIG encoding

Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>

* Reformat test_fireeye.py

Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>

---------

Signed-off-by: Harsh Mishra <hmisraji07@gmail.com>
Co-authored-by: Tushar Goel <34160672+TG1999@users.noreply.github.com
66CE
>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TG1999 TG1999 TG1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harsh098 @TG1999
0