10000 Add basic UI template for API by pombredanne · Pull Request #1466 · aboutcode-org/vulnerablecode · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add basic UI template for API #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Add basic UI template for API #1466

merged 1 commit into from
Jul 16, 2024

Conversation

pombredanne
Copy link
Member

Borrowed from ScanCode.io

Reference: #1465
Thanks-to: Thomas Druez @tdruez

@pombredanne pombredanne requested a review from johnmhoran April 24, 2024 13:57
Copy link
Member
@johnmhoran johnmhoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

body {background: none;}
.navbar {background: #363636; border-top: 3px solid #3298dc;}
.navbar-inverse .navbar-brand {color: white;}
.nexb-blue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems problematic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does, good eye, looks like somebody started to define the CSS for .next-blue and got distracted, never finished. @pombredanne , where did this code come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.navbar-inverse .navbar-brand {color: white;}
.nexb-blue
.booleanwidget {width: 90%;}

You need to remove the .nexb-blue line, it's not a correct syntax.

@TG1999
Copy link
Contributor
TG1999 commented Jul 9, 2024

@pombredanne please have a look when you get a chance and merge it! Thanks!

body {background: none;}
.navbar {background: #363636; border-top: 3px solid #3298dc;}
.navbar-inverse .navbar-brand {color: white;}
.nexb-blue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.navbar-inverse .navbar-brand {color: white;}
.nexb-blue
.booleanwidget {width: 90%;}

You need to remove the .nexb-blue line, it's not a correct syntax.

Borrowed from ScanCode.io

Reference: #1465
Thanks-to: Thomas Druez @tdruez
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne
Copy link
Member Author

Changes applied. Will merge shortly! @tdruez thanks

@pombredanne
Copy link
Member Author

@tdruez all fixed. @TG1999 please review and merge

@pombredanne pombredanne merged commit 7e2a70a into main Jul 16, 2024
11 checks passed
@pombredanne pombredanne deleted the api-template branch July 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0