8000 Release/1.1.11 by sacOO7 · Pull Request #211 · ably/ably-php · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Release/1.1.11 #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2025
Merged

Release/1.1.11 #211

merged 2 commits into from
Mar 7, 2025

Conversation

sacOO7
Copy link
Collaborator
@sacOO7 sacOO7 commented Mar 5, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Documentation
    • Updated the release notes to version 1.1.11, including details on closed issues and merged updates.
  • New Features
    • Introduced support for PHP 8.4.
  • Bug Fixes
    • Resolved an issue affecting batch publishing data formats.
  • Chores
    • Updated the library version to 1.1.11.

@sacOO7 sacOO7 marked this pull request as ready for review March 5, 2025 10:58
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Mar 5, 2025 •
edited
Loading

Walkthrough

The pull request introduces version 1.1.11 by updating the changelog and the version constant. The changelog now documents a new release entry dated March 5, 2025, listing closed issues (including PHP 8.4 deprecations and a batch publish bug) and merged pull requests (adding PHP 8.4 support and fixing the batch publish issue). Additionally, the LIB_VERSION constant in the Defaults class has been incremented from 1.1.10 to 1.1.11.

Changes

File(s) Change Summary
CHANGELOG.md Added a new version entry for 1.1.11 (dated March 5, 2025) with sections listing closed issues and merged pull requests related to PHP 8.4 support and bug fixes.
src/Defaults.php Updated the LIB_VERSION constant from 1.1.10 to 1.1.11.

Poem

I'm a little code rabbit, hopping through the night,
With version bumps so shiny, everything feels just right.
Bugs and issues scurry, fixed with a careful touch,
PHP updates and changelogs, oh, I love them so much!
Leaping into code with joy, my heart sings in delight.
Here's to new versions—bright as a star in the night!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 4912f24 and 024ed2c.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms (16)
  • GitHub Check: check (8.4, msgpack)
  • GitHub Check: check (8.4, json)
  • GitHub Check: check (8.3, msgpack)
  • GitHub Check: check (8.3, json)
  • GitHub Check: check (8.2, msgpack)
  • GitHub Check: check (8.2, json)
  • GitHub Check: check (8.1, msgpack)
  • GitHub Check: check (8.1, json)
  • GitHub Check: check (8, msgpack)
  • GitHub Check: check (8, json)
  • GitHub Check: check (7.4, msgpack)
  • GitHub Check: check (7.4, json)
  • GitHub Check: check (7.3, msgpack)
  • GitHub Check: check (7.3, json)
  • GitHub Check: check (7.2, msgpack)
  • GitHub Check: check (7.2, json)
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot temporarily deployed to staging/pull/211/features March 5, 2025 10:58 Inactive
@sacOO7 sacOO7 requested review from AndyTWF and ttypic March 5, 2025 10:59
coderabbitai[bot]
coderabbitai bot reviewed Mar 5, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
CHANGELOG.md (1)

9-11: Issue List Review:

  • The list of closed issues is comprehensive and relevant.
  • On line 10, note the use of escaped square brackets (\[Question\]). If these escapes are not required for proper Markdown rendering, consider removing them for consistency with other list entries.
🧰 Tools
🪛 LanguageTool

[uncategorized] ~10-~10: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...bly-php/issues/206) - [Question] Does ably-php support Queues [#200](https://github.c...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eaecef2 and 4912f24.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • src/Defaults.php (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • src/Defaults.php
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[uncategorized] ~10-~10: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...bly-php/issues/206) - [Question] Does ably-php support Queues [#200](https://github.c...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

⏰ Context from checks skipped due to timeout of 90000ms (16)
  • GitHub Check: check (8.4, msgpack)
  • GitHub Check: check (8.4, json)
  • GitHub Check: check (8.3, msgpack)
  • GitHub Check: check (8.3, json)
  • GitHub Check: check (8.2, msgpack)
  • GitHub Check: check (8.2, json)
  • GitHub Check: check (8.1, msgpack)
  • GitHub Check: check (8.1, json)
  • GitHub Check: check (8, msgpack)
  • GitHub Check: check (8, json)
  • GitHub Check: check (7.4, msgpack)
  • GitHub Check: check (7.4, json)
  • GitHub Check: check (7.3, msgpack)
  • GitHub Check: check (7.3, json)
  • GitHub Check: check (7.2, msgpack)
  • GitHub Check: check (7.2, json)
🔇 Additional comments (5)
CHANGELOG.md (5)

3-4: Version Entry Accuracy:
Ensure that the new release version entry for 1.1.11 is formatted consistently with previous entries and that the release date (2025-03-05) is correct.

5-6: Changelog Link Validation:
Verify that the "Full Changelog" link accurately compares versions 1.1.10 and 1.1.11. The URL should correctly reflect the intended diff.

7-8: Section Header Clarity:
The "Closed issues:" header is clear and appropriately distinguishes the upcoming list.

13-14: Merged Pull Requests Header:
The header "Merged pull requests:" is clear and consistent with the established format in the changelog.

15-17: Merged PRs Verification:
Confirm that the merged pull requests, including the associated identifiers and contributor links, are accurate. The formatting and link structure appear correct.

AndyTWF
AndyTWF approved these changes Mar 5, 2025
View reviewed changes
@sacOO7 sacOO7 merged commit ddd9355 into main Mar 7, 2025
18 checks passed
@sacOO7 sacOO7 deleted the release/1.1.11 branch March 7, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@AndyTWF AndyTWF AndyTWF approved these changes

@ttypic ttypic ttypic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sacOO7 @AndyTWF @ttypic
0