8000 MG-163 - Add snap to grid effect on layout by felixgateru · Pull Request #175 · absmach/magistrala-ui-old · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

MG-163 - Add snap to grid effect on layout #175

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

MG-163 - Add snap to grid effect on layout #175

wants to merge 13 commits into from

Conversation

felixgateru
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Dependency Update

What does this do?

Adds snap to grid effect on the layout.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

  • Yes
  • No, and this is why:

Did you document any new/modified functionality?

8000
  • Yes
  • No, and this is why:

Notes

@felixgateru felixgateru force-pushed the MG-163-snap_to_grid branch 2 times, most recently from d1c78be to 0250027 Compare February 27, 2024 07:35
ianmuchyri
ianmuchyri suggested changes Feb 27, 2024
View reviewed changes
ui/web/templates/dashboard.html Outdated
@@ -14,6 +14,9 @@
crossorigin="anonymous"
referrerpolicy="no-referrer"
></script>
<link rel="stylesheet" href="//code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css" />
<script src="//code.jquery.com/jquery-3.6.0.min.js"></script>
<script src="//code.jquery.com/ui/1.12.1/jquery-ui.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this jquery being used?
remove unused importations

@felixgateru felixgateru force-pushed the MG-163-snap_to_grid branch 4 times, most recently from 8c071a6 to 754197d Compare March 6, 2024 10:29
@dborovcanin dborovcanin force-pushed the MG-163-snap_to_grid branch from 754197d to ac17bd9 Compare March 6, 2024 10:43
@felixgateru felixgateru force-pushed the MG-163-snap_to_grid branch 2 times, most recently from afbba48 to 4766bab Compare March 6, 2024 10:58
@felixgateru felixgateru marked this pull request as ready for review March 6, 2024 10:59
@felixgateru felixgateru force-pushed the MG-163-snap_to_grid branch 2 times, most recently from 19ba86c to a08e0ab Compare March 7, 2024 16:59
dborovcanin
dborovcanin suggested changes Mar 7, 2024
View reviewed changes
ui/web/static/js/dashboard.js Outdated
grid.refreshItems();
grid.layout(true);
document.removeEventListener("mouseup", finalizeResize);
console.log("Resize finalized");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove debug logs.

ui/web/templates/dashboard.html Outdated
8000
@@ -14,6 +14,7 @@
crossorigin="anonymous"
referrerpolicy="no-referrer"
></script>
<link rel="stylesheet" href="//code.jquery.com/ui/1.12.1/themes/base/jquery-ui.css" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was used in a previous implementation with jquery but has now been removed.

@felixgateru felixgateru force-pushed the MG-163-snap_to_grid branch from a08e0ab to d74ddf4 Compare March 18, 2024 08:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@38b1017). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #175   +/-   ##
=======================================
  Coverage        ?   76.74%           
=======================================
  Files           ?        3           
  Lines           ?      215           
  Branches        ?        0           
=======================================
  Hits            ?      165           
  Misses          ?       34           
  Partials        ?       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felixgateru felixgateru force-pushed the MG-163-snap_to_grid branch 2 times, most recently from 7b4b05a to d4d8211 Compare March 18, 2024 08:44
@ianmuchyri
Copy link
Contributor

some charts are not snapping to the grid:
Screencast from 18-03-24 12:33:57.webm
Only the first one snaps to the grid.

@dborovcanin dborovcanin force-pushed the MG-163-snap_to_grid branch from 6d41b8d to 66068c0 Compare March 18, 2024 15:24
@ianmuchyri
Copy link
Contributor

@1998-felix there is a scroll bar that appears at the bottom that is not required:
image

@felixgateru
Add abstractions for widgets and charts
40965f3 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
Remove redundant functions
0d97aaf 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
Refactor
c20d11b 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
Refactor
51c8fec 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
Add private methods for chart creation
942da4b 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
feat: Add snap to grid effect on layout
2709cd8 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
Add resizing per chart
5979c61 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
Add resize helper
177b698 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
Add final resizing function
8000
cfe919e 
Signed-off-by: felix.gateru <felix.gateru@gmail.com>
@felixgateru
fix: Snap to grid once
b95c833 
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
@felixgateru
feat: Make grid visible on resizing
f2aa2e0 
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
@felixgateru
fix: Remove bottom scrollbar
9d2f6bd 
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
@felixgateru
fix: Remove bottom scrollbar
f9ce97b 
Signed-off-by: 1998-felix <felix.gateru@gmail.com>
@felixgateru felixgateru force-pushed the MG-163-snap_to_grid branch from 66068c0 to f9ce97b Compare March 19, 2024 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dborovcanin dborovcanin dborovcanin requested changes

@ianmuchyri ianmuchyri ianmuchyri requested changes

At least 2 approving reviews are required to merge this pull request.

Assignees No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add snap-to-grid effect on the layout
4 participants
@felixgateru @codecov-commenter @ianmuchyri @dborovcanin
0