8000 NOISSUE - Remove UI from docker-compose by manuio · Pull Request #1001 · absmach/supermq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NOISSUE - Remove UI from docker-compose #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2020
Merged

NOISSUE - Remove UI from docker-compose #1001

merged 2 commits into from
Jan 15, 2020

Conversation

manuio
Copy link
Contributor
@manuio manuio commented Jan 14, 2020

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

@manuio
NOISSUE - Remove UI from docker-compose
acb76b0 
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner January 14, 2020 21:45
@codecov-io
Copy link

Codecov Report

Merging #1001 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1001   +/-   ##
=======================================
  Coverage   79.78%   79.78%           
=======================================
  Files          95       95           
  Lines        6551     6551           
=======================================
  Hits         5227     5227           
  Misses       1010     1010           
  Partials      314      314

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba1717...acb76b0. Read the comment docs.

drasko
drasko previously approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor
@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko
Copy link
Contributor
drasko commented Jan 14, 2020

Approved. We should note somewhere in the documentation how UI should be run, for the people that want to run Mainflux with UI.

mteodor
mteodor previously approved these changes Jan 15, 2020
View reviewed changes
@nmarcetic
Copy link
Collaborator

@manuio Remove from .env also.

@manuio
Rm MF_UI_PORT envar
2106cd4 
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio dismissed stale reviews from mteodor and drasko via 2106cd4 January 15, 2020 13:43
drasko
drasko approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor
@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 160fda4 into absmach:master Jan 15, 2020
manuio added a commit that referenced this pull request Oct 12, 2020
@manuio @drasko
NOISSUE - Remove UI from docker-compose (#1001)
b7717f9 
* NOISSUE - Remove UI from docker-compose

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Rm MF_UI_PORT envar

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio deleted the ui branch February 23, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drasko drasko drasko approved these changes

@dborovcanin dborovcanin dborovcanin approved these changes

@mteodor mteodor mteodor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@manuio @codecov-io @drasko @nmarcetic @mteodor @dborovcanin
0