MF-1053 - Add disconnect event to MQTT adapter #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
blokovi
previously approved these changes
Mar 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #1056 +/- ##
==========================================
+ Coverage 79.03% 79.06% +0.03%
==========================================
Files 95 95
Lines 6610 6610
==========================================
+ Hits 5224 5226 +2
+ Misses 1076 1075 -1
+ Partials 310 309 -1
Continue to review full report at Codecov.
|
nmarcetic
reviewed
Mar 3, 2020
mqtt/adapter.go
Outdated
| e.logger.Info(fmt.Sprintf("Error in mqtt publish %s", err)) | ||
| return | ||
| for _, mp := range e.pubs { | ||
| if err := mp.Publish(context.TODO(), "", msg); err != nil { |
There was a problem hiding this comment.
Can we have async publish with a separate routine for each publisher?
golangcibot
reviewed
Mar 3, 2020
mqtt/adapter.go
Outdated
| return | ||
| for _, mp := range e.pubs { | ||
| go func() { | ||
| if err := mp.Publish(context.TODO(), "", msg); err != nil { |
There was a problem hiding this comment.
loopclosure: loop variable mp captured by func literal (from govet)
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
nmarcetic
approved these changes
Mar 3, 2020
blokovi
approved these changes
Mar 3, 2020
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add disconnect event to mProxy Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Rename publishers to pubs Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com> * Use acync publishers Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dušan Borovčanin dusan.borovcanin@mainflux.com
What does this do?
This pull request updates MQTT adapter to use the most recent version of
mProxy(0.1.1). It also introduces minor optimizations and code refactoring.Which issue(s) does this PR fix/relate to?
This pull request resolves #1053.
List any changes that modify/break current functionality
A package rename might cause some issues in case you're importing the MQTT adapter package.
Have you included tests for your changes?
No.
Did you document any new/modified functionality?
No.