8000 NOISSUE - Remove unused Tokenizer interface from User service by blokovi · Pull Request #1084 · absmach/supermq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

NOISSUE - Remove unused Tokenizer interface from User service #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2020
Merged

NOISSUE - Remove unused Tokenizer interface from User service #1084

merged 1 commit into from
Mar 25, 2020

Conversation

blokovi
Copy link
Contributor
@blokovi blokovi commented Mar 25, 2020

Signed-off-by: Ivan Milošević iva@blokovi.com

@blokovi blokovi requested a review from a team as a code owner March 25, 2020 09:11
@blokovi
Remove unused Tokenizer interface
34aa3d0 
Signed-off-by: Ivan Milošević <iva@blokovi.com>
@manuio manuio changed the title [NOISSUE] Remove unused Tokenizer interface from User service NOISSUE - Remove unused Tokenizer interface from User service Mar 25, 2020
manuio
manuio approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor
@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1084 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1084   +/-   ##
=======================================
  Coverage   78.01%   78.01%           
=======================================
  Files          95       95           
  Lines        6672     6672           
=======================================
  Hits         5205     5205           
  Misses       1157     1157           
  Partials      310      310

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ffa916...34aa3d0. Read the comment docs.

@manuio manuio merged commit a2d70c8 into absmach:master Mar 25, 2020
@blokovi blokovi deleted the deltoken branch April 6, 2020 14:48
manuio pushed a commit that referenced this pull request Oct 12, 2020
@blokovi
Remove unused Tokenizer interface (#1084)
6ba708c 
Signed-off-by: Ivan Milošević <iva@blokovi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mteodor mteodor mteodor approved these changes

@manuio manuio manuio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blokovi @codecov-io @mteodor @manuio
0